Replace void filtering with monostate in when_all#227
Replace void filtering with monostate in when_all#227mvandeberg merged 1 commit intocppalliance:developfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR extracts a shared Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6d5fd12 to
0cea4bb
Compare
|
An automated preview of the documentation is available at https://227.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-03-11 22:28:27 UTC |
0cea4bb to
0a0bb31
Compare
|
GCOVR code coverage report https://227.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-03-11 22:36:59 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #227 +/- ##
===========================================
- Coverage 92.41% 92.36% -0.05%
===========================================
Files 162 162
Lines 8854 8854
===========================================
- Hits 8182 8178 -4
- Misses 672 676 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Closes #204
Summary by CodeRabbit
Release Notes
when_allto consistently handle void-returning tasks by including them in the result tuple as std::monostate values, preserving input indices and enabling uniform tuple aggregation for mixed task combinations.