Merged
Conversation
MahdiBaghbani
force-pushed
the
fix-openapi-specification
branch
4 times, most recently
from
f15dedf to
0dcea93
Compare
Member
|
Merging #181 first and then this one |
Member
|
Hm GitHub didn't understand that this PR was based on top of #181, @MahdiBaghbani could you please rebase? Also, I have a comment on the |
glpatcern
reviewed
Jun 2, 2025
Co-authored-by: Mahdi Baghbani <Mahdi.baghbani1@gmail.com>
This work was being done by Mahdi, will use his implementation This reverts commit 11d9c9e.
MahdiBaghbani
force-pushed
the
fix-openapi-specification
branch
from
0dcea93 to
7a245ed
Compare
MahdiBaghbani
force-pushed
the
fix-openapi-specification
branch
2 times, most recently
from
6fc7d88 to
4cd56fe
Compare
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
MahdiBaghbani
force-pushed
the
fix-openapi-specification
branch
from
4cd56fe to
3b65218
Compare
glpatcern
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR #181
Added
serverssection to remove the URL parts before the/in thepaths, Also beneficial when testing a live EFSS by simply entering its base URL and then playing with the commands in Swagger UIFixed the
patternPropertiesby removing it and moving the known parts under protocols and optional arbitrary protocols underadditionalProperties, seems to fix the swagger validatorAdded an example for RO-Crate as an optional protocol
