[#2712] Cap system power to 100% if no Reactor or Coolant#2809
Open
oznogon wants to merge 1 commit intodaid:masterfrom
Open
[#2712] Cap system power to 100% if no Reactor or Coolant#2809oznogon wants to merge 1 commit intodaid:masterfrom
oznogon wants to merge 1 commit intodaid:masterfrom
Conversation
Don't allow systems to be overpowered to 300% if they lack both Reactor and Coolant components. Otherwise the entity gains the benefits of overpowering for free, without generating heat or losing power. Update Engineering and Power Management screens to reduce the power bar range in this situation, and to hide heat indicators and coolant controls if there's no Coolant component.
oznogon
changed the title
daid
reviewed
Mar 25, 2026
| float power_max = 3.0f; | ||
| if (my_spaceship) | ||
| { | ||
| has_coolant = my_spaceship.hasComponent<Coolant>(); |
Owner
There was a problem hiding this comment.
While I think the change concept is good. This would set the limit only when the screen is created, so if you dynamically add or remove a reactor/coolant system, there will be inconsistent behavior.
Contributor
Author
There was a problem hiding this comment.
Could've sworn that I caught that, and I know I tested it. Will check if I left a local commit when I'm at my computer again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't allow systems to be overpowered to 300% if they lack both Reactor and Coolant components. Otherwise the entity gains the benefits of overpowering for free, without generating heat or losing power.
Update Engineering and Power Management screens to reduce the power bar range in this situation, and to hide heat indicators and coolant controls if there's no Coolant component.
Fixes #2712.