Refactor drawLine to use quads instead of GL_LINES#293
Open
oznogon wants to merge 2 commits intodaid:masterfrom
Open
Refactor drawLine to use quads instead of GL_LINES#293oznogon wants to merge 2 commits intodaid:masterfrom
oznogon wants to merge 2 commits intodaid:masterfrom
Conversation
Owner
|
I see some FSAA changes in here but that was also handled by #293, any idea if there is some duplication? |
Refactor drawLine...() functions to draw lines using quads and a shader. The quad line shader is defined inline. drawCircleOutline() and drawRectOutline() (formerly outlineRect()) also now accept a defined thickness/width. Also: - Original `drawLine` is `drawGLLine` - Calculate circle point counts based on pixel counts instead of using a fixed value, for smoother circles
oznogon
force-pushed
the
new-sp-line-drawing
branch
from
4853162 to
64acc19
Compare
Contributor
Author
Contributor
Author
|
Also to note that daid/EmptyEpsilon#2707 updates calls on the EE end to specify line width/thickness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #292 (FSAA implementation).
Refactor drawLine...() functions to draw lines using quads and a shader. The quad line shader is defined inline.
drawCircleOutline() and drawRectOutline() (formerly outlineRect()) also now accept a defined thickness/width.
Also:
drawLine...functions are retained but deprecated asdrawGLLine...