chore(shared): strict-fix core context providers (ENG-803 batch 2a)#5578
Open
rebelchris wants to merge 4 commits intomainfrom
Open
chore(shared): strict-fix core context providers (ENG-803 batch 2a)#5578rebelchris wants to merge 4 commits intomainfrom
rebelchris wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
capJavert
reviewed
Feb 25, 2026
Comment on lines
81
to
92
| showLogin: () => { | ||
| throw new Error('showLogin is not available outside AuthContextProvider'); | ||
| }, | ||
| closeLogin: () => { | ||
| throw new Error('closeLogin is not available outside AuthContextProvider'); | ||
| }, | ||
| logout: async () => { | ||
| throw new Error('logout is not available outside AuthContextProvider'); | ||
| }, | ||
| updateUser: async () => { | ||
| throw new Error('updateUser is not available outside AuthContextProvider'); | ||
| }, |
Contributor
There was a problem hiding this comment.
this is bound to break some stuff, auth context was optional before so basically we need keep it like that instead of hiding it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- fix strict typing in core shared context providers\n- add strict-safe defaults/guards for auth, boot, settings, alerts and related providers\n- keep behavior unchanged while removing undefined/null strict violations\n\n## Scope\n- packages/shared/src/contexts/{AlertContext,AuthContext,BootProvider,BootProvider.spec,DndContext,FeedContext,NotificationsContext,PushNotificationContext,SettingsContext,SubscriptionContext,WritePostContext}.tsx\n\n## Validation\n- pnpm --filter shared lint:fix\n- pnpm --filter shared lint\n- pnpm --filter shared typecheck:strict (targeted scope clean)\n- pnpm --filter shared test -- --testPathPattern="src/contexts"\n\n## Notes\n- shared/webapp non-strict typecheck still has existing baseline failures outside this PR scope.
Preview domain
https://codex-eng-803-batch2-context-cor.preview.app.daily.dev