Skip to content

Simplify install of aocc compiler#802

Merged
danieljprice merged 7 commits intomasterfrom
aocc
Feb 24, 2026
Merged

Simplify install of aocc compiler#802
danieljprice merged 7 commits intomasterfrom
aocc

Conversation

@danieljprice
Copy link
Owner

Description:
Now that setup-fortran workflow supports the aocc compiler, fix the build workflow to use the official procedure

Components modified:

  • Setup (src/setup)
  • Main code (src/main)
  • Moddump utilities (src/utils/moddump)
  • Analysis utilities (src/utils/analysis)
  • Test suite (src/tests)
  • Documentation (docs/)
  • Build/CI (build/ or github actions)

Type of change:

  • Bug fix
  • Physics improvements
  • Better initial conditions
  • Performance improvements
  • Documentation update
  • Better testing
  • Code cleanup / refactor
  • Other (please describe)

Testing:
Will be tested in the actions

Did you run the bots? yes

Did you update relevant documentation in the docs directory? no

Did you add comments such that the purpose of the code is understandable? yes

Is there a unit test that could be added for this feature/bug? no

Related issues: #792

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @danieljprice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on integrating and documenting the growth_coala module within the codebase. It updates module dependencies to correctly reflect the use of growth_coala in various parts of the simulation, expands its internal documentation with detailed runtime parameters, and updates copyright information. Additionally, a new parameter for dust options was introduced, and a file owner was corrected. It is important to note that the actual changes in the code do not align with the pull request's stated title and description, which refer to simplifying the installation of the AOCC compiler.

Highlights

  • Module Dependency Updates: The growth_coala module has been integrated into the dependency lists of several core modules, including evolve, initial, and readwrite_infile, ensuring proper linkage within the codebase.
  • Enhanced Documentation for growth_coala: The growth_coala.F90 file now includes comprehensive documentation for its runtime parameters, detailing various coagulation-related settings such as Q_coag, alpha_turb, brow_grow, and kernel.
  • Copyright Year Updates: Copyright years in growth_coala.F90 and test_coala.F90 have been updated from 2025 to 2026.
  • New Dust Option Parameter: A new runtime parameter, ndust_max_mrn, has been added to set_dust_options.f90 to control the maximum number of grain size bins for power-law profiles.
  • File Owner Correction: The owner of test_gravity.f90 has been corrected from Yann Bernard to Daniel Price.
  • Discrepancy with PR Title/Description: It is important to note that the actual code changes in this pull request, which primarily involve Fortran module dependencies, documentation, and minor code adjustments, do not align with the stated pull request title ('Simplify install of aocc compiler') and description, which refer to build workflow and compiler setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/evolve.f90
    • Added growth_coala to the module's dependency list.
  • src/main/growth_coala.F90
    • Updated copyright year from 2025 to 2026.
    • Expanded the documentation for runtime parameters, listing several new coagulation-related parameters.
    • Updated the module's dependency list to include more specific coala_ related modules.
    • Removed extraneous blank lines and adjusted indentation for consistency.
    • Ensured a newline at the end of the file.
  • src/main/initial.F90
    • Added growth_coala to the module's dependency list.
  • src/main/readwrite_infile.f90
    • Added growth_coala to the module's dependency list.
  • src/setup/set_dust_options.f90
    • Added ndust_max_mrn to the list of runtime parameters.
  • src/tests/test_coala.F90
    • Updated copyright year from 2025 to 2026.
    • Replaced growth_smol with growth_coala in the module's dependency list.
  • src/tests/test_gravity.f90
    • Updated the module owner from Yann Bernard to Daniel Price.
  • src/tests/testsuite.f90
    • Adjusted the order of dependencies, moving testcoala earlier in the list.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build.yml
Activity
  • No specific activity (comments, reviews, or progress) was provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the growth_coala module for dust coagulation, updates dependency lists, and includes stylistic improvements. Please update the PR title and description as they currently refer to simplifying AOCC compiler installation, which does not match the code changes. A security review found no vulnerabilities. Additionally, there is a suggestion to improve the documentation for the new runtime parameters.

@danieljprice danieljprice merged commit 9a990b7 into master Feb 24, 2026
534 of 538 checks passed
@danieljprice danieljprice deleted the aocc branch February 24, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant