chore: v23.1.0 release#7139
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughThis pull request updates configure.ac to bump internal client version values (_CLIENT_VERSION_MINOR 0→1, _CLIENT_VERSION_BUILD 2→0, _CLIENT_VERSION_IS_RELEASE false→true). It updates doc/release-notes.md to change the release from v23.0.2 to v23.1.0 and expands/restructures the Notable changes. Many individual release-note files have had specific entries removed. A new comprehensive release-notes/dash/release-notes-23.0.2.md document was added detailing v23.0.2 features, bug fixes, and dependencies. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@doc/release-notes.md`:
- Around line 177-178: The two release entries for v23.0.2 and v23.0.1 use
abbreviated month/year only—update the date strings to include the specific day
to match the format used elsewhere (e.g., change "Jan/2026" and "Dec/2025" to
something like "Jan/XX/2026" and "Dec/XX/2025" with the correct release days) in
the lines referencing [v23.0.2] and [v23.0.1] so the file doc/release-notes.md
uses a consistent "Mon/DD/YYYY" style across all entries.
🧹 Nitpick comments (1)
doc/release-notes.md (1)
121-121: Minor grammar nit: "wallet related" → "wallet-related".Compound adjective before a noun should be hyphenated.
-Changes to wallet related RPCs can be found in the Wallet section below. +Changes to wallet-related RPCs can be found in the Wallet section below.
|
|
||
| - Dash Core binaries now target Windows 10 and macOS 14 (Sonoma), replacing the previous targets of Windows 7 and | ||
| macOS 11 (Big Sur). (#6927) | ||
| - The minimum supported Clang version has been bumped to Clang 19 for improved C++20 support and diagnostics. (#6995) |
There was a problem hiding this comment.
wait; clang-19 is used for CI indeed; but does it really required to get dash core build? @kwvg
ba7098c to
3925e38
Compare
|
base branch should be https://github.com/dashpay/dash/tree/v23.1.x, not develop |
kwvg
left a comment
There was a problem hiding this comment.
Comment could be misunderstood to mean simultaneous rescans are possible
3925e38 to
7043a4e
Compare
|
All should be resolved |
7043a4e to
63c2179
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@doc/release-notes.md`:
- Line 118: The phrase "Changes to wallet related RPCs can be found in the
Wallet section below." uses "wallet related" as a compound adjective; update
that phrase to "wallet-related" so it reads "Changes to wallet-related RPCs can
be found in the Wallet section below." Locate the exact string "Changes to
wallet related RPCs can be found in the Wallet section below." and replace with
the hyphenated version.
In `@doc/release-notes/dash/release-notes-23.0.2.md`:
- Line 103: The release note entry for v0.15.0.0 contains a typo
"Febrary/18/2020"; update the text in the markdown line that starts with
"[v0.15.0.0](...)" replacing "Febrary" with "February" so it reads
"February/18/2020".
🧹 Nitpick comments (1)
doc/release-notes/dash/release-notes-23.0.2.md (1)
3-3: Minor style preference: consider "bug fixes" as two words.While "bugfixes" as one word is acceptable in technical writing, "bug fixes" (two words) is more formal and commonly preferred in release documentation.
✨ Suggested style improvement
-This is a new patch version release, bringing various bugfixes, performance improvements, and new tooling for database maintenance. +This is a new patch version release, bringing various bug fixes, performance improvements, and new tooling for database maintenance.
|
forgot to include/drop |
63c2179 to
890ba6d
Compare
|
resolved |
890ba6d to
8429352
Compare
|
Resolved both |
doc/release-notes.md
Outdated
| - Vijay | ||
| - thephez | ||
| - UdjinM6 | ||
| - zxccxccxz |
There was a problem hiding this comment.
or actually even
| - Vijay | |
| - thephez | |
| - UdjinM6 | |
| - zxccxccxz | |
| - thephez | |
| - UdjinM6 | |
| - Vijay | |
| - zxccxccxz |
Archive the v23.0.1 and v23.0.2 release notes into doc/release-notes/dash/. Write v23.1.0 release notes covering all changes since v23.0.2 (187 merged PRs). Remove per-PR release note files that have been incorporated into the main release notes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8429352 to
9c29abf
Compare
Issue being fixed or feature implemented
Release v23.1.0
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.