Skip to content

chore: v23.1.0 release#7139

Merged
PastaPastaPasta merged 3 commits intodashpay:v23.1.xfrom
PastaPastaPasta:chore/23.1-release
Feb 13, 2026
Merged

chore: v23.1.0 release#7139
PastaPastaPasta merged 3 commits intodashpay:v23.1.xfrom
PastaPastaPasta:chore/23.1-release

Conversation

@PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Release v23.1.0

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 23.1 milestone Feb 13, 2026
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

Walkthrough

This pull request updates configure.ac to bump internal client version values (_CLIENT_VERSION_MINOR 0→1, _CLIENT_VERSION_BUILD 2→0, _CLIENT_VERSION_IS_RELEASE false→true). It updates doc/release-notes.md to change the release from v23.0.2 to v23.1.0 and expands/restructures the Notable changes. Many individual release-note files have had specific entries removed. A new comprehensive release-notes/dash/release-notes-23.0.2.md document was added detailing v23.0.2 features, bug fixes, and dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (41 files):

⚔️ configure.ac (content)
⚔️ contrib/seeds/nodes_main.txt (content)
⚔️ contrib/seeds/nodes_test.txt (content)
⚔️ contrib/seeds/onion_seeds.txt (content)
⚔️ doc/release-notes.md (content)
⚔️ src/Makefile.qt.include (content)
⚔️ src/chainparams.cpp (content)
⚔️ src/chainparamsseeds.h (content)
⚔️ src/governance/governance.cpp (content)
⚔️ src/governance/governance.h (content)
⚔️ src/governance/object.cpp (content)
⚔️ src/interfaces/node.h (content)
⚔️ src/interfaces/wallet.h (content)
⚔️ src/node/interface_ui.cpp (content)
⚔️ src/node/interface_ui.h (content)
⚔️ src/node/interfaces.cpp (content)
⚔️ src/qt/bitcoingui.cpp (content)
⚔️ src/qt/bitcoingui.h (content)
⚔️ src/qt/clientmodel.cpp (content)
⚔️ src/qt/clientmodel.h (content)
⚔️ src/qt/dash.qrc (content)
⚔️ src/qt/forms/governancelist.ui (content)
⚔️ src/qt/forms/optionsdialog.ui (content)
⚔️ src/qt/governancelist.cpp (content)
⚔️ src/qt/governancelist.h (content)
⚔️ src/qt/guiconstants.h (content)
⚔️ src/qt/masternodelist.cpp (content)
⚔️ src/qt/masternodelist.h (content)
⚔️ src/qt/mnemonicverificationdialog.cpp (content)
⚔️ src/qt/mnemonicverificationdialog.h (content)
⚔️ src/qt/optionsdialog.cpp (content)
⚔️ src/qt/optionsmodel.cpp (content)
⚔️ src/qt/optionsmodel.h (content)
⚔️ src/qt/proposalmodel.cpp (content)
⚔️ src/qt/proposalmodel.h (content)
⚔️ src/qt/res/css/dark.css (content)
⚔️ src/qt/res/css/general.css (content)
⚔️ src/qt/res/css/light.css (content)
⚔️ src/version.h (content)
⚔️ src/wallet/interfaces.cpp (content)
⚔️ test/util/data/non-backported.txt (content)

These conflicts must be resolved before merging into v23.1.x.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: v23.1.0 release' clearly and concisely summarizes the main change: bumping the version to v23.1.0 and preparing the release.
Description check ✅ Passed The description identifies the issue as 'Release v23.1.0' which is directly related to the changeset; however, most explanatory sections ('What was done?', 'How Has This Been Tested?', 'Breaking Changes') are empty.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch chore/23.1-release
  • Post resolved changes as copyable diffs in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@doc/release-notes.md`:
- Around line 177-178: The two release entries for v23.0.2 and v23.0.1 use
abbreviated month/year only—update the date strings to include the specific day
to match the format used elsewhere (e.g., change "Jan/2026" and "Dec/2025" to
something like "Jan/XX/2026" and "Dec/XX/2025" with the correct release days) in
the lines referencing [v23.0.2] and [v23.0.1] so the file doc/release-notes.md
uses a consistent "Mon/DD/YYYY" style across all entries.
🧹 Nitpick comments (1)
doc/release-notes.md (1)

121-121: Minor grammar nit: "wallet related" → "wallet-related".

Compound adjective before a noun should be hyphenated.

-Changes to wallet related RPCs can be found in the Wallet section below.
+Changes to wallet-related RPCs can be found in the Wallet section below.


- Dash Core binaries now target Windows 10 and macOS 14 (Sonoma), replacing the previous targets of Windows 7 and
macOS 11 (Big Sur). (#6927)
- The minimum supported Clang version has been bumped to Clang 19 for improved C++20 support and diagnostics. (#6995)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait; clang-19 is used for CI indeed; but does it really required to get dash core build? @kwvg

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knst those changes were made in anticipation of dash#7109 which is no longer scheduled for v23.1, so it is not (but was originally expected to be)

@UdjinM6
Copy link

UdjinM6 commented Feb 13, 2026

base branch should be https://github.com/dashpay/dash/tree/v23.1.x, not develop

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment could be misunderstood to mean simultaneous rescans are possible

@PastaPastaPasta PastaPastaPasta changed the base branch from develop to v23.1.x February 13, 2026 19:54
@PastaPastaPasta
Copy link
Member Author

All should be resolved

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@doc/release-notes.md`:
- Line 118: The phrase "Changes to wallet related RPCs can be found in the
Wallet section below." uses "wallet related" as a compound adjective; update
that phrase to "wallet-related" so it reads "Changes to wallet-related RPCs can
be found in the Wallet section below." Locate the exact string "Changes to
wallet related RPCs can be found in the Wallet section below." and replace with
the hyphenated version.

In `@doc/release-notes/dash/release-notes-23.0.2.md`:
- Line 103: The release note entry for v0.15.0.0 contains a typo
"Febrary/18/2020"; update the text in the markdown line that starts with
"[v0.15.0.0](...)" replacing "Febrary" with "February" so it reads
"February/18/2020".
🧹 Nitpick comments (1)
doc/release-notes/dash/release-notes-23.0.2.md (1)

3-3: Minor style preference: consider "bug fixes" as two words.

While "bugfixes" as one word is acceptable in technical writing, "bug fixes" (two words) is more formal and commonly preferred in release documentation.

✨ Suggested style improvement
-This is a new patch version release, bringing various bugfixes, performance improvements, and new tooling for database maintenance.
+This is a new patch version release, bringing various bug fixes, performance improvements, and new tooling for database maintenance.

@PastaPastaPasta PastaPastaPasta requested review from knst and kwvg February 13, 2026 20:07
kwvg
kwvg previously approved these changes Feb 13, 2026
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 63c2179

@UdjinM6
Copy link

UdjinM6 commented Feb 13, 2026

forgot to include/drop doc/release-note-26194.md?

@PastaPastaPasta
Copy link
Member Author

resolved

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed 2 contributors

@PastaPastaPasta
Copy link
Member Author

Resolved both

Comment on lines 160 to 163
- Vijay
- thephez
- UdjinM6
- zxccxccxz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or actually even

Suggested change
- Vijay
- thephez
- UdjinM6
- zxccxccxz
- thephez
- UdjinM6
- Vijay
- zxccxccxz

PastaPastaPasta and others added 2 commits February 13, 2026 15:14
Archive the v23.0.1 and v23.0.2 release notes into doc/release-notes/dash/. Write v23.1.0 release notes covering all changes since v23.0.2 (187 merged PRs). Remove per-PR release note files that have been incorporated into the main release notes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9c29abf

@PastaPastaPasta PastaPastaPasta merged commit 0b7f5be into dashpay:v23.1.x Feb 13, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants