Skip to content

Conversation

@ilyakuz-db
Copy link
Contributor

@ilyakuz-db ilyakuz-db commented Feb 2, 2026

Changes

  1. Support changing fields that have CLI defaults but not defined in the config
  2. Support adding new tasks when task array already exists
  3. Support task renaming (new field will be added, previously - error)
  4. Add an explicit reset value for the queue.enabled, as remote returns it as nil when the queueing is disabled, and we can't define nil in config
  5. Simplify logic with server-side defaults using reflect.DeepEqual, and move them to a separate file defaults.go
  6. Remove SDK JSON marshaling round-trip, use dyn.FromTyped instead

Why

Some bugs were found after testing the feature in the workspace

Tests

Added tests for new tasks, task renames, and for CLI defaults

@ilyakuz-db ilyakuz-db marked this pull request as ready for review February 3, 2026 10:02
@ilyakuz-db ilyakuz-db changed the title Config sync new defaults Support changing CLI defaults in config-sync Feb 3, 2026
@@ -41,11 +41,4 @@
rename_task_job:
tasks:
- - task_key: task_rename_1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When task_key is renamed, we create a new task with this key.

Not sure if we should try to be more clever here, potentially we could always insert at the same position where something was removed, to minimize the diff when the task_key was renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants