-
Notifications
You must be signed in to change notification settings - Fork 139
Support changing CLI defaults in config-sync #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ilyakuz-db
wants to merge
38
commits into
main
Choose a base branch
from
config-sync-new-defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bd138ca.
…into config-sync-new-defaults
ilyakuz-db
commented
Feb 3, 2026
| @@ -41,11 +41,4 @@ | ||
| rename_task_job: | ||
| tasks: | ||
| - - task_key: task_rename_1 |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When task_key is renamed, we create a new task with this key.
Not sure if we should try to be more clever here, potentially we could always insert at the same position where something was removed, to minimize the diff when the task_key was renamed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
queue.enabled, as remote returns it asnilwhen the queueing is disabled, and we can't definenilin configreflect.DeepEqual, and move them to a separate filedefaults.godyn.FromTypedinsteadWhy
Some bugs were found after testing the feature in the workspace
Tests
Added tests for new tasks, task renames, and for CLI defaults