Skip to content

switch to cql2#236

Draft
vincentsarago wants to merge 5 commits intomainfrom
feature/switch-to-cql2
Draft

switch to cql2#236
vincentsarago wants to merge 5 commits intomainfrom
feature/switch-to-cql2

Conversation

@vincentsarago
Copy link
Member

@bitner I could need some help to finish this PR

def bbox_to_wkt(bbox: List[float], srid: int = 4326) -> str:
"""Return WKT representation of a BBOX."""
poly = Polygon.from_bounds(*bbox) # type:ignore
return f"SRID={srid};{poly.wkt}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go, we don't need to set the CRS anymore

# ),
# logic.V(geometry_column.name),
# )
# )
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Spatial filter

@vincentsarago
Copy link
Member Author

Note: for this PR to go through we will need to get rid of buildpg

cc @bitner

@francbartoli
Copy link

I'm just wondering if the switch has in its scope the validation of the CQL-TEXT/CQL-JSON in the request. If not, is this feature planned or of interest?


# default to cql2-text
return cql2_text_parser(query)
return Expr(query)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francbartoli In this PR the validation should be done here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, the use of dependencies already makes the validation clean

@vincentsarago
Copy link
Member Author

I'm just wondering if the switch has in its scope the validation of the CQL-TEXT/CQL-JSON in the request. If not, is this feature planned or of interest?

Yeah it should be done when we switch to CQL2 library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments