Skip to content

fix: update error for wrong resource id #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kulikp1 wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: update error for wrong resource id #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions adminforth/spa/src/components/BreadcrumbsWithButtons.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
<slot></slot>
</div>
</div>
<div class="flex items-center justify-between mb-3 flex-wrap gap-y-2 gap-2" v-if="coreStore.resourceColumnsError">
<div class="p-4 mb-4 text-sm text-red-800 rounded-lg bg-red-50 dark:bg-gray-800 dark:text-red-400" role="alert">
<span class="font-medium">{{ $t('Error!')}}</span> {{ coreStore.resourceColumnsError }}
</div>

<div class="absolute inset-0 z-50 bg-white " v-if="coreStore.resourceColumnsError">
Copy link
Collaborator

@SerVitasik SerVitasik Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must specify the v-if
Because what if resourceColumnsError is not related to incorrect url ?
We should not show 404 page in this case

<PageNotFound/>
</div>
</div>

</template>

<script setup>
import Breadcrumbs from '@/components/Breadcrumbs.vue';
import Breadcrumbs from '@/components/Breadcrumbs.vue';
import PageNotFound from '@/views/PageNotFound.vue';

import { useCoreStore } from '@/stores/core';

Expand Down