Conversation
|
Noticed that: Will come back with a random port instead of the default fixed port. Seems to be set here: https://github.com/dfinity/icp-cli/blob/main/crates/icp/src/network/mod.rs#L120 |
| }; | ||
|
|
||
| // Friendly domains are available for managed networks where we write custom-domains.txt | ||
| let has_friendly = matches!( |
There was a problem hiding this comment.
This is assuming that all network launchers and all docker images are going to support the custom domains which is not a safe assumption to make IMO.
I think we can simplify this and continue printing the <canister>.<localhost>:<port> url because it is more likely to be correct.
It would be documented that some network can use the friendly names - maybe it can even be printed when the network starts if this network will support friendly names.
There was a problem hiding this comment.
I'm going to narrow it to 'is it native and is the version latest' for now, I want to keep the feature advertised to users and this should be enough following the auto-update PR. The launcher notifying the CLI whether it is supported seems like a good idea.
| let domain = gateway_domain(http_gateway_url); | ||
| let mut candid_url = canister_gateway_url(http_gateway_url, ui_id, None); | ||
| if domain.is_some() { | ||
| candid_url.set_query(Some(&format!("id={canister_id}"))); |
There was a problem hiding this comment.
as a side note - could be interesting to create a friendly name for the candid ui canister too.
There was a problem hiding this comment.
I agree but would rather keep it out of this PR.
3 participants
No description provided.