Open
Conversation
… page - Work in progress
… on slide page + Code cleanup
…aces-2.0 into story/VSPC-147
… them, fixed code indentations and div alignments
… shown on public page
…ography not detected by zotero extension
…detection by zotero - work in progress
…aphy, handling null cases of path variables, code cleanup
…rategy Design pattern
…ged Biblio controller and forms - Saving is working - Work in Progress
jdamerow
requested changes
Oct 30, 2025
Member
jdamerow
left a comment
jdamerow
left a comment
There was a problem hiding this comment.
Also, there are codefactor issues and what happened to all the classes in the "references" package (e.g. https://github.com/diging/virtual-spaces-2.0/pull/299/files#diff-8e2f9f515ef07dfc360ae67df0401001f8cd6b89b960b99068f972b3fd962eec)
| reference.setEditors(editor); | ||
| reference.setType(type); | ||
| reference.setNote(note); | ||
| if(visibility == "Private") { |
Member
There was a problem hiding this comment.
strings should not be hard-coded; at a minimum this needs to be a constant somewhere
|
|
||
| private String note; | ||
|
|
||
| private boolean visibility; |
Member
There was a problem hiding this comment.
boolean variables should be adjectives so that the methods make sense when you call them is... (i.e. isVisibility does not make much sense...)
Member
|
Make it so, Jenkins. |
jdamerow
requested changes
Nov 7, 2025
| @RequestMapping(value = "/staff/module/{id}/slide/{slideId}/bibliography/{biblioId}/reference/add", | ||
| method = RequestMethod.POST) | ||
| public ResponseEntity<IReference> addReference(@PathVariable("id") String moduleId, | ||
| public ResponseEntity<Reference> addReference(@PathVariable("id") String moduleId, |
Member
There was a problem hiding this comment.
is this needed? why the change?
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
Add Bibliography section to staff page
Like users or images, it should show all references sortable by author, year, title, or created date.
VSPC-150
Anything else the reviewer needs to know?
The previous PR for this branch 299 has a force push and hence cannot be re opened.