Merged
Conversation
eerhardt
commented
Mar 16, 2026
mitchdenny
approved these changes
Mar 23, 2026
radical
approved these changes
Mar 23, 2026
There was a problem hiding this comment.
Pull request overview
Updates the solution’s .NET Aspire AppHost SDK and related dependency pins to align with Aspire 13.2 across the app host and functional test app hosts.
Changes:
- Bump
Aspire.AppHost.Sdkto13.2.0for the main AppHost and functional test AppHosts. - Update central package versions in
Directory.Packages.props(Aspire 13.2, Grpc, ASP.NET packages, OpenTelemetry, EF tooling, etc.). - Refresh a few supporting library pins (e.g.,
Microsoft.OpenApi,Google.Protobuf,Grpc.Tools).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Ordering.FunctionalTests/Ordering.FunctionalTests.csproj | Bumps AppHost SDK to 13.2.0 for the Ordering functional test host. |
| tests/Catalog.FunctionalTests/Catalog.FunctionalTests.csproj | Bumps AppHost SDK to 13.2.0 for the Catalog functional test host. |
| src/eShop.AppHost/eShop.AppHost.csproj | Bumps main AppHost SDK to 13.2.0. |
| Directory.Packages.props | Updates centralized dependency version pins to match the Aspire upgrade and related ecosystem updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
markdownlint-cli 0.48.0 requires Node.js >= 20. The v regex flag used by its string-width dependency is not supported in Node.js 16. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Without a health check, WaitFor(identityApi) only waits for the process to start, not for the HTTP server to be fully initialized. This caused Playwright login tests to fail on CI because the WebApp would start before the Identity API was ready to handle requests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.