JIT: remove anticipated demand for throw helpers #123781

AndyAyersMS · 2026-01-29T23:01:45Z

Historically morph would signal to the backend that a throw helper might be needed from a certain block by calling fgAddCodeRef. This scheme is less viable now that we have targets like Wasm where null checks must be explicit.

Modify the JIT so that throw helper demand and throw helper block/call creation is all done during the stack level setting phase, so there is no need to anticipate if throw helpers will be needed in advance.

Also, always minimize the set of common throw helpers needed if not generating debuggable code (where throw helper calls are "in line").

Historically morph would signal to the backend that a throw helper might be needed from a certain block by calling `fgAddCodeRef`. This scheme is less viable now that we have targets like Wasm where null checks must be explicit. Modify the JIT so that throw helper demand and throw helper block/call creation is all done during the stack level setting phase, so there is no need to anticipate if throw helpers will be needed in advance. Also, always minimize the set of common throw helpers needed if not generating debuggable code (where throw helper calls are "in line").

Copilot

Pull request overview

This PR moves throw-helper “demand” and throw-helper block/call creation out of morph and into the stack-level setting phase, avoiding the need to anticipate helper usage (notably for targets like Wasm that require explicit null checks).

Changes:

Removed morph-time “anticipation” of throw helpers by deleting fgAddCodeRef calls at morph sites.
Reworked throw-helper infrastructure to create AddCodeDsc entries and blocks on demand during stack-level setting (fgCreateAddCodeDsc, fgCreateThrowHelperBlock, updated fgFindExcptnTarget).
Ensured throw helper code insertion and unused-helper pruning happens during StackLevelSetter.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/coreclr/jit/stacklevelsetter.cpp	Centralizes throw-helper discovery and creation during stack-level setting; updates helper usage tracking/removal.
src/coreclr/jit/morph.cpp	Removes morph-time throw-helper “demand” signaling (`fgAddCodeRef` calls).
src/coreclr/jit/lower.cpp	Updates comment to reflect that throw-helper calls may occur (not necessarily known upfront).
src/coreclr/jit/flowgraph.cpp	Replaces `fgAddCodeRef` with descriptor/block creation APIs and adjusts helper-block creation flow.
src/coreclr/jit/compiler.h	Updates declarations for new throw-helper APIs and exposes `fgRngChkThrowAdded`.
src/coreclr/jit/compiler.cpp	Removes the dedicated “create throw helpers” phase from the pipeline.
src/coreclr/jit/codegencommon.cpp	Updates comment wording around sharing throw helper blocks.

src/coreclr/jit/stacklevelsetter.cpp

AndyAyersMS · 2026-01-29T23:13:22Z

FYI @dotnet/jit-contrib

Mainly motivated by Wasm, but reduces coupling overall.

There is more cleanup that could be done, since we should no longer need to update ACDs when adding or removing EH regions, but I've left that code in place for now. It will be bypassed at runtime since the ACD map will be empty when phases that modify EH run.

A modest number of more or less neutral diffs, some from throw helper blocks being reordered, and some places where we now insert an explicit nop before a NOGC region where we didn't before, because this check in lower

runtime/src/coreclr/jit/lower.cpp

Line 3335 in 062177e

if ((comp->fgBBcount == 1) && !comp->compCurBB->HasFlag(BBF_GC_SAFE_POINT))

fired when we created throw helper blocks before lower, but now we defer creation until after, and so in more cases now there's just one block (and in the example I look at the throw helper block ended up unused and was removed).

And a few diffs where the allocator behaves differently.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

src/coreclr/jit/flowgraph.cpp

EgorBo · 2026-01-30T11:45:58Z

Nice to see this hack go away from morph. Any idea why the TP is up to +0.86% for MinOpts?
I presume the size regressions are mostly from longer jump instructions.

AndyAyersMS · 2026-01-30T15:42:44Z

Any idea why the TP is up to +0.86% for MinOpts?

If we are going to use throw helper blocks (which we do unless we are asked for debugggable codegen) we have to walk the IR now even in minopts to figure out where we need throw helpers. So this is roughly the cost of that IR walk.

Previously we relied on the upstream demands to describe all the helpers we would need, so didn't need to do this walk.

AndyAyersMS · 2026-01-30T16:19:55Z

Previously we relied on the upstream demands to describe all the helpers we would need, so didn't need to do this walk.

We might be able to mitigate this cost somewhat if we can determine that we won't need any throw helpers in some upstream phase (eg there are no oper may throw GTF_EXCEPT nodes). I would guess a decent fraction of methods don't need any helpers. But it might end up being fragile.

EgorBo · 2026-01-30T16:21:55Z

Previously we relied on the upstream demands to describe all the helpers we would need, so didn't need to do this walk.

We might be able to mitigate this cost somewhat if we can determine that we won't need any throw helpers in some upstream phase (eg there are no oper may throw GTF_EXCEPT nodes). I would guess a decent fraction of methods don't need any helpers. But it might end up being fragile.

Yeah, kind of similar to insert-gc-polls phase, which can rely on a BBF_ flag for Tier0. Although, for that phase it's not catastrophic if it misses something

AndyAyersMS · 2026-01-30T18:57:15Z

The SPMI asmdiff failure is in a method with runtime async, we blow up trying to display a movw and the immediate field on the instr desc is 0.

This PR has modified block layout slightly.

****** START compiling System.Net.Mail.Tests.LoopbackSmtpServer:HandleConnectionAsync(System.Net.Sockets.Socket):this (MethodHash=368e01e1) (Context 171447)
...
Generating: N267 (  1,  1) [004431] -----------                 t4431 =    ASYNC_RESUME_INFO int    state=0 REG r1
IN05e0:             movw    r1,

With just disasm it blows up later, during emit display

G_M65054_IG174:  ;; offset=0x10F4
0010F4      mov     r0, r2
0010F6      movw    r1, 0x93bc
0010FA      movt    r1, 0xe2e4
0010FE      movw    r3, 0x72a1
001102      movt    r3, 0xede4
001106      blx     r3          // CORINFO_HELP_ALLOC_CONTINUATION
001108      mov     r6, r0
00110A      movw    r1, ISSUE: <ASSERT> #171447 C:\repos\runtime3\src\coreclr\jit\emitarm.cpp (7308) - Assertion failed 'jdsc != NULL' in 'System.Net.Mail.Tests.LoopbackSmtpServer:HandleConnectionAsync(System.Net.Sockets.Socket):this' during 'Emit code' (IL size 1629; hash 0x368e01e1; FullOpts)

@jakobbotsch does this sound at all familiar?

jakobbotsch · 2026-01-30T18:58:04Z

The throughput optimization is relatively new (#112561). I personally think it's ok to trade it off for the robustness we get here.

jakobbotsch · 2026-01-30T19:01:27Z

The SPMI asmdiff failure is in a method with runtime async, we blow up trying to display a movw and the immediate field on the instr desc is 0.

This PR has modified block layout slightly.

****** START compiling System.Net.Mail.Tests.LoopbackSmtpServer:HandleConnectionAsync(System.Net.Sockets.Socket):this (MethodHash=368e01e1) (Context 171447)
...
Generating: N267 (  1,  1) [004431] -----------                 t4431 =    ASYNC_RESUME_INFO int    state=0 REG r1
IN05e0:             movw    r1,

With just disasm it blows up later, during emit display

G_M65054_IG174:  ;; offset=0x10F4
0010F4      mov     r0, r2
0010F6      movw    r1, 0x93bc
0010FA      movt    r1, 0xe2e4
0010FE      movw    r3, 0x72a1
001102      movt    r3, 0xede4
001106      blx     r3          // CORINFO_HELP_ALLOC_CONTINUATION
001108      mov     r6, r0
00110A      movw    r1, ISSUE: <ASSERT> #171447 C:\repos\runtime3\src\coreclr\jit\emitarm.cpp (7308) - Assertion failed 'jdsc != NULL' in 'System.Net.Mail.Tests.LoopbackSmtpServer:HandleConnectionAsync(System.Net.Sockets.Socket):this' during 'Emit code' (IL size 1629; hash 0x368e01e1; FullOpts)

@jakobbotsch does this sound at all familiar?

Hmm, no, I haven't seen this before.
Are you sure this particular issue isn't a jitdump issue and that the issue spmi otherwise hits is something else?

AndyAyersMS · 2026-01-30T19:15:51Z

I think it's a dump/disasm only issue. This bit of code doesn't look for asyncResumeInfo section types.

Seems like we can just generalize it.

runtime/src/coreclr/jit/emitarm.cpp

Lines 7284 to 7308 in 918254d

    
           case IF_T2_N2: 
        
               emitDispReg(id->idReg1(), attr, true); 
        
               imm = emitGetInsSC(id); 
        
               { 
        
                   dataSection*  jdsc = 0; 
        
                   NATIVE_OFFSET offs = 0; 
        
                   /* Find the appropriate entry in the data section list */ 
        
                   for (jdsc = emitConsDsc.dsdList; jdsc; jdsc = jdsc->dsNext) 
        
                   { 
        
                       UNATIVE_OFFSET size = jdsc->dsSize; 
        
                       /* Is this a label table? */ 
        
                       if (jdsc->dsType == dataSection::blockAbsoluteAddr) 
        
                       { 
        
                           if (offs == imm) 
        
                               break; 
        
                       } 
        
                       offs += size; 
        
                   } 
        
                   assert(jdsc != NULL);

AndyAyersMS · 2026-01-30T19:58:04Z

Seems like we can just generalize it.

Not so simple. Maybe we need a new IF... for references to the async data so it can be displayed properly.

AndyAyersMS · 2026-01-30T20:02:17Z

Opened #123813 for this arm32 failure.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

src/coreclr/jit/flowgraph.cpp

Fix range mechanics Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/stacklevelsetter.cpp:190

checkForHelpers is now always initialized to true, making the surrounding optimization-related comment and the subsequent checkForHelpers |= !framePointerRequired logic redundant. Consider simplifying this block (or updating the comment) so it reflects the new always-check behavior.

        // When optimizing we want to know what throw helpers might be used
        // so we can remove the ones that aren't needed.
        //
        // If we're not optimizing then the helper requests made in
        // morph are likely still accurate, so we don't bother checking
        // if helpers are indeed used.
        //
        bool checkForHelpers = true;

#if !FEATURE_FIXED_OUT_ARGS
        // Even if not optimizing, if we have a moving SP frame, a shared helper may
        // be reached with mixed stack depths and so force this method to use
        // a frame pointer. Once we see that the method will need a frame
        // pointer we no longer need to check for this case.
        //
        checkForHelpers |= !framePointerRequired;
#endif

        if (checkForHelpers)
        {

src/coreclr/jit/stacklevelsetter.cpp

src/coreclr/jit/flowgraph.cpp

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/codegenwasm.cpp:1206

fgGetExcptnTarget no longer returns nullptr (it creates an AddCodeDsc on demand), so the if (add == nullptr)/assert(add != nullptr) block is now dead code. More importantly, if a null-check demand was missed earlier, this code will still proceed and may end up dereferencing a null add->acdDstBlk in non-assert builds. Consider replacing the null check with a check for the expected preconditions (e.g., add->acdUsed and/or add->acdDstBlk != nullptr) and keep the NYI_WASM("Missing null check demand") behavior for that case.

        Compiler::AddCodeDsc* const add = compiler->fgGetExcptnTarget(SCK_NULL_CHECK, compiler->compCurBB);

        if (add == nullptr)
        {
            NYI_WASM("Missing null check demand");
        }

        assert(add != nullptr);
        assert(add->acdUsed);
        GetEmitter()->emitIns_I(INS_I_const, EA_PTRSIZE, compiler->compMaxUncheckedOffsetForNullObject);
        GetEmitter()->emitIns(INS_I_le_u);
        inst_JMP(EJ_jmpif, add->acdDstBlk);

src/coreclr/jit/flowgraph.cpp

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/codegenwasm.cpp:1199

fgGetExcptnTarget no longer returns nullptr (it creates an AddCodeDsc on-demand), so this if (add == nullptr) / NYI_WASM branch is now dead code. More importantly, the thing that can actually be null here is add->acdDstBlk when the helper block wasn’t created; consider removing this null check and instead validating add->acdDstBlk (ideally with a noway_assert) before using it in inst_JMP.

        Compiler::AddCodeDsc* const add = compiler->fgGetExcptnTarget(SCK_NULL_CHECK, compiler->compCurBB);

        if (add == nullptr)
        {
            NYI_WASM("Missing null check demand");

src/coreclr/jit/flowgraph.cpp

adamperlin

The pieces I understand look good to me. It looks like that outstanding copilot suggestion about the comment may still be relevant?

Co-authored-by: Copilot <[email protected]>

AndyAyersMS · 2026-01-31T00:23:23Z

The pieces I understand look good to me. It looks like that outstanding copilot suggestion about the comment may still be relevant?

Thanks. I went with copilot's suggestion here.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/codegenwasm.cpp:1203

The if (add == nullptr) / NYI_WASM("Missing null check demand") path is now effectively dead: fgGetExcptnTarget currently creates a new AddCodeDsc when none exists, so add won't be null here. If the intent is to require that stacklevelsetter has already created the null-check helper block, consider removing this null check and instead asserting that add->acdDstBlk is non-null (or adjust fgGetExcptnTarget to return nullptr when no entry exists and createIfNeeded is false).

        Compiler::AddCodeDsc* const add = compiler->fgGetExcptnTarget(SCK_NULL_CHECK, compiler->compCurBB);

        if (add == nullptr)
        {
            NYI_WASM("Missing null check demand");
        }

        assert(add != nullptr);
        assert(add->acdUsed);

src/coreclr/jit/flowgraph.cpp

AndyAyersMS · 2026-01-31T17:29:52Z

SPMI failure is #123813

AndyAyersMS · 2026-01-31T18:08:17Z

For the other failures: looks like codegen for some NAOT HW intrinsic feature tests must have changed. The validation does an inspection of the code stream:

runtime/src/tests/nativeaot/SmokeTests/HardwareIntrinsics/Program.cs

Lines 616 to 636 in 087c690

    
           static bool IsConstantTrue(delegate*<bool> code) 
        
           { 
        
               return 
        
                   // mov eax, 1; ret 
        
                   memcmp((byte*)code, new byte[] { 0xB8, 0x01, 0x00, 0x00, 0x00, 0xC3 }) 
        
                   // push rbp; sub rsp, 10h; lea rbp, [rsp+10h]; mov dword ptr [rbp-4], 1 
        
                   || memcmp((byte*)code, new byte[] { 0x55, 0x48, 0x83, 0xEC, 0x10, 0x48, 0x8D, 0x6C, 0x24, 0x10, 0xC7, 0x45, 0xFC, 0x01, 0x00, 0x00, 0x00 }) 
        
                   // push rbp; push rdi; push rax; lea rbp, [rsp+10h]; mov dword ptr [rbp-C], 1 
        
                   || memcmp((byte*)code, new byte[] { 0x55, 0x57, 0x50, 0x48, 0x8D, 0x6C, 0x24, 0x10, 0xC7, 0x45, 0xF4, 0x01, 0x00, 0x00, 0x00 }); 
        
           } 
        
           static bool IsConstantFalse(delegate*<bool> code) 
        
           { 
        
               return 
        
                   // xor eax, eax; ret 
        
                   memcmp((byte*)code, new byte[] { 0x33, 0xC0, 0xC3 }) 
        
                   // push rbp; sub rsp, 10h; lea rbp, [rsp+10h]; xor eax, eax 
        
                   || memcmp((byte*)code, new byte[] { 0x55, 0x48, 0x83, 0xEC, 0x10, 0x48, 0x8D, 0x6C, 0x24, 0x10, 0x33, 0xC0 }) 
        
                   // push rbp; push rdi; push rax; lea rbp, [rsp+10h]; xor eax, eax 
        
                   || memcmp((byte*)code, new byte[] { 0x55, 0x57, 0x50, 0x48, 0x8D, 0x6C, 0x24, 0x10, 0x33, 0xC0 }); 
        
           }

## Description ARM32 JIT dump/disasm asserts when encountering async resume info references. The `IF_T2_N2` instruction format handles both block address tables and async resume info, but the dump logic only expected the former. ## Changes - **Remove assert in `emitarm.cpp:7308`**: Was failing when `jdsc` is null (async resume info case) - **Add null check before table dump**: Skip inline block address table dump when `jdsc` is null - **Use `nullptr` instead of `NULL`**: Modern C++ style throughout the code block - **Add conditional printing**: Print `RWD%02zu` format for async resume info (when `jdsc` is null) and `J_M%03u_DS%02u` format for block address tables (when `jdsc` is not null) - **Clarify comment**: Document when `jdsc` is null vs non-null The fix preserves all existing dump behavior for block address tables while allowing async resume info to display properly without assertion. ```cpp // Before: would assert if jdsc is null and always print as DS format assert(jdsc != NULL); printf("... J_M%03u_DS%02u", ...); if (id->idIns() == INS_movt) { /* dump table using jdsc */ } // After: skip table dump when jdsc is null and use appropriate format if (jdsc != nullptr) printf("... J_M%03u_DS%02u", ...); // block address table else printf("... RWD%02zu", ...); // async resume info if (jdsc != nullptr && id->idIns() == INS_movt) { /* dump table using jdsc */ } ``` Affects dump/disasm output only; no impact on code generation.  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>JIT: fix arm32 dump/disasm of references to async resume info</issue_title> > <issue_description>See #123781 (comment) > > Seemingly `IF_T2_N2` expects the data to resolve to a table of block addresses, so if we reuse this form for references to async resume info it doesn't display properly. > > I think this just impacts dumping and disasm. But not 100% sure. > </issue_description> > > <agent_instructions>Fix this issue by handling gracefully the situation where `jdsc` is null -- skip the inline table dump logic in that case</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details>  - Fixes #123813  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/runtime/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jakobbotsch <[email protected]>

AndyAyersMS · 2026-01-31T20:15:07Z

New codegen - the stack frame is bigger now because this is debuggable codegen and NAOT didn't have the starup hook we see for jitted code. Only happens for debuggable leaf NAOT methods so the actual stack size increase is not a big deal.

X64Avx2_Program__X86BaseIsSupported:
  00000001401596E0: 55                 push        rbp
  00000001401596E1: 57                 push        rdi
  00000001401596E2: 48 83 EC 28        sub         rsp,28h
  00000001401596E6: 48 8D 6C 24 30     lea         rbp,[rsp+30h]
  00000001401596EB: C7 45 F4 01 00 00  mov         dword ptr [rbp-0Ch],1
                    00
  00000001401596F2: 8B 45 F4           mov         eax,dword ptr [rbp-0Ch]
  00000001401596F5: 0F B6 C0           movzx       eax,al
  00000001401596F8: 48 83 C4 28        add         rsp,28h
  00000001401596FC: 5F                 pop         rdi
  00000001401596FD: 5D                 pop         rbp
  00000001401596FE: C3                 ret
  00000001401596FF: 90

Copilot AI review requested due to automatic review settings January 29, 2026 23:01

github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 29, 2026

dotnet-policy-service bot assigned AndyAyersMS Jan 29, 2026

Copilot started reviewing on behalf of AndyAyersMS January 29, 2026 23:02 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

src/coreclr/jit/stacklevelsetter.cpp Show resolved Hide resolved

src/coreclr/jit/stacklevelsetter.cpp Outdated Show resolved Hide resolved

Copilot AI reviewed Jan 29, 2026

View reviewed changes

adamperlin reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Outdated Show resolved Hide resolved

This was referenced Jan 30, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

fixes for wasm

71aa49b

build-analysis bot mentioned this pull request Jan 30, 2026

iOS.Device test WorkItemExecutions #122874

Open

EgorBo reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Show resolved Hide resolved

review feedback

b866da3

EgorBo approved these changes Jan 30, 2026

View reviewed changes

Merge branch 'main' into NoAcdDemands

522c9d9

AndyAyersMS mentioned this pull request Jan 30, 2026

JIT: fix arm32 dump/disasm of references to async resume info #123813

Closed

Copilot AI review requested due to automatic review settings January 30, 2026 20:02

Copilot started reviewing on behalf of AndyAyersMS January 30, 2026 20:03 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Outdated Show resolved Hide resolved

Update src/coreclr/jit/flowgraph.cpp

fbb3a85

Fix range mechanics Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 30, 2026 20:15

Copilot started reviewing on behalf of AndyAyersMS January 30, 2026 20:16 View session

fix comment; fix copilot code

90771bf

Copilot AI reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/stacklevelsetter.cpp Show resolved Hide resolved

src/coreclr/jit/stacklevelsetter.cpp Show resolved Hide resolved

src/coreclr/jit/flowgraph.cpp Show resolved Hide resolved

AndyAyersMS added 2 commits January 30, 2026 13:45

clarify behavior of fgGetExcptnTarget

2ae4a68

shore up what we do for debuggable codegen

5b1b315

Copilot AI review requested due to automatic review settings January 30, 2026 23:18

Copilot started reviewing on behalf of AndyAyersMS January 30, 2026 23:18 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Outdated Show resolved Hide resolved

Update src/coreclr/jit/flowgraph.cpp

84539b4

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 30, 2026 23:31

Copilot started reviewing on behalf of AndyAyersMS January 30, 2026 23:32 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Outdated Show resolved Hide resolved

adamperlin approved these changes Jan 30, 2026

View reviewed changes

Update src/coreclr/jit/flowgraph.cpp

41fce61

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 31, 2026 00:22

Copilot started reviewing on behalf of AndyAyersMS January 31, 2026 00:23 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

src/coreclr/jit/flowgraph.cpp Show resolved Hide resolved

src/coreclr/jit/flowgraph.cpp Show resolved Hide resolved

build-analysis bot mentioned this pull request Jan 31, 2026

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

AndyAyersMS added 2 commits January 31, 2026 12:38

add additional case to hw intrinsic pattern matches

840c1ff

Merge branch 'main' into NoAcdDemands

958915e

AndyAyersMS merged commit cb83a15 into dotnet:main Jan 31, 2026
128 of 131 checks passed

dotnet-maestro bot mentioned this pull request Feb 1, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#4581

Open

JIT: remove anticipated demand for throw helpers #123781

JIT: remove anticipated demand for throw helpers #123781

Conversation

AndyAyersMS commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

AndyAyersMS commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

EgorBo commented Jan 30, 2026

Uh oh!

AndyAyersMS commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyAyersMS commented Jan 30, 2026

Uh oh!

EgorBo commented Jan 30, 2026

Uh oh!

AndyAyersMS commented Jan 30, 2026

Uh oh!

jakobbotsch commented Jan 30, 2026

Uh oh!

jakobbotsch commented Jan 30, 2026

Uh oh!

AndyAyersMS commented Jan 30, 2026

Uh oh!

AndyAyersMS commented Jan 30, 2026

Uh oh!

AndyAyersMS commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

adamperlin left a comment

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS commented Jan 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

AndyAyersMS commented Jan 31, 2026

Uh oh!

AndyAyersMS commented Jan 31, 2026

Uh oh!

AndyAyersMS commented Jan 31, 2026

Uh oh!

Uh oh!

AndyAyersMS commented Jan 30, 2026 •

edited

Loading