-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add CLI project for managed ilasm #123822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
|
Code coverage is pretty much the same: With cli, we can perform ad-hoc testing and align the implementation with relative ease. Perhaps quicker way would be to get the fresh list of missing things / TODOs is by replacing native ilasm with managed one in src/tests ( |
|
I think we should definitely introduce a new test lane in the runtime-coreclr ilasm pipeline that replaces the native ilasm with the managed one. That will help us figure out what we need for parity (and that being green is our acceptance criteria for the new ilasm implementation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd like to ship this as a NativeAOT'd tool eventually. Can we set <AotOrSingleFile> to true for this project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think of it separately; how we want to support community platforms (with --bootstrap): #123822 (comment).
How about the following plan:
After that, we can iterate with ongoing development and fixes. I ran some ad-hoc tests ( |
No description provided.