-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix LinkLabel contrast in Dark Mode #14283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix LinkLabel contrast in Dark Mode #14283
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14283 +/- ##
===================================================
+ Coverage 77.18395% 77.18743% +0.00348%
===================================================
Files 3279 3279
Lines 645138 645153 +15
Branches 47730 47730
===================================================
+ Hits 497943 497977 +34
+ Misses 143503 143487 -16
+ Partials 3692 3689 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates LinkLabel’s default link colors when Dark Mode is enabled to improve contrast and align with the reported usability issue (#11935).
Changes:
- Adjust
LinkColordefault in Dark Mode to a brighter blue for better readability. - Adjust
ActiveLinkColordefault in Dark Mode to a red tone for clearer click/active feedback. - Update
VisitedLinkColordefault selection logic to useLinkUtilities.GetVisitedLinkColor()when Dark Mode is enabled.
Fixes #11935
Proposed changes
LinkColor (normal link state):
Color.FromArgb(102, 178, 255)- A bright blue that contrasts well with dark backgroundsActiveLinkColor (when link is being clicked):
Color.FromArgb(255, 128, 128)- Light red color for clear visual feedbackVisitedLinkColor (after link has been visited):
Color.FromArgb(200, 162, 255)- Light purple color for a visible visited stateCustomer Impact
Regression?
Risk
Screenshots
Before
BeforeChanges.mp4
After
AfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow