Merged
Conversation
sirainen
requested changes
Feb 12, 2026
sirainen
requested changes
Feb 12, 2026
slusarz
force-pushed
the
parsing_fixes
branch
2 times, most recently
from
aca63e2 to
8336bc2
Compare
Pipelined commands were incorrectly failing validation due to an incorrect connection index comparison in test_parse_command_line(). The code was comparing the 0-based stored group->connection_idx against the 1-based connection_idx parsed from the test file. Additionally, when using multiple connections in scripted tests, command replies must be prefixed with the connection index. The parser was failing to recognize this prefix for pipelined commands, leading to "Tag reused" errors because the connection index was misinterpreted as a tag or command name. Update test_parse_command_line() to correctly identify and skip the connection index prefix when parsing replies in multi-connection tests.
Found by tester. A command with a connection ID must have a connection ID for the response tag if using method 2
slusarz
force-pushed
the
parsing_fixes
branch
from
8336bc2 to
130c21f
Compare
sirainen
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly centered around connection IDs and pipelining.
Added a test program to quickly test parsing of scripts.