Add files to be translated in french Canadian#1893
Open
jadehamel wants to merge 1 commit intoergochat:masterfrom
Open
Add files to be translated in french Canadian#1893jadehamel wants to merge 1 commit intoergochat:masterfrom
jadehamel wants to merge 1 commit intoergochat:masterfrom
Conversation
Member
|
Thanks, this is great! @DanielOaks can you take a look at how this interacts with our recommended workflow for translations? Should these preferably be submitted to Crowdin? If we merge this PR here, will Crowdin pick it up? |
Author
thank you I was waiting some reviews before to put more work on thoses files. |
Contributor
|
I see two issues:
Otherwise, it looks good to me (as a French person). |
Contributor
|
Oh, I just realized it's an issue in the existing translation... I guess these should be fixed first, then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm asking for a merge on a W.I.P. so it could be easyier to follow the diff for other contributers...