Potential fix for code scanning alert no. 150: Resolving XML external entity in user-controlled data#3
Draft
alvinsmith-eroad wants to merge 1 commit intomasterfrom
Draft
Potential fix for code scanning alert no. 150: Resolving XML external entity in user-controlled data#3alvinsmith-eroad wants to merge 1 commit intomasterfrom
alvinsmith-eroad wants to merge 1 commit intomasterfrom
Conversation
… entity in user-controlled data Please excuse this unsolicited pull request. I wanted to share it as Copilot identified what appears to be a fine solution. However, I defer to the team's judgment. Feel free to either merge or close it. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/eroad/keycloak/security/code-scanning/150
To fully mitigate XXE vulnerabilities when parsing untrusted XML with StAX, you must disable both external entity resolution and DTD support. The code already sets
XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIEStofalse, but it does not setXMLInputFactory.SUPPORT_DTDtofalse. The best fix is to add the following line after the other property settings in thegetXMLEventReadermethod inStaxParserUtil.java:This ensures that DTDs are not processed at all, closing the XXE vector. No changes to imports or method signatures are required, as
XMLInputFactory.SUPPORT_DTDis already available.Suggested fixes powered by Copilot Autofix. Review carefully before merging.