Add akd_traits crate with KeyDirectory trait#482
Draft
kevinlewi wants to merge 1 commit intofacebook:mainfrom
Draft
Add akd_traits crate with KeyDirectory trait#482kevinlewi wants to merge 1 commit intofacebook:mainfrom
kevinlewi wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Introduce an abstract KeyDirectory trait that defines the interface for any key directory implementation, with both server-side operations (publish, lookup, key_history, audit) and client-side verification. - Create akd_traits crate as the leaf dependency (no internal deps) - Define DirectoryLabel, DirectoryValue, EpochHash, VerifyResult, and Digest in akd_traits - Have akd_core depend on akd_traits, with backward-compatible type aliases (AkdLabel = DirectoryLabel, AkdValue = DirectoryValue) - Implement KeyDirectory for akd::Directory - Add generic benchmarking harness (BenchmarkSetup trait) with Criterion benchmark functions - Add scaling benchmark CLI (examples/scaling-bench) with database caching, sweep mode, and multiple output formats
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 88.61% 88.50% -0.12%
==========================================
Files 39 40 +1
Lines 9109 7533 -1576
==========================================
- Hits 8072 6667 -1405
+ Misses 1037 866 -171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
akd_traitscrate as the leaf dependency defining the abstractKeyDirectorytrait for any key directory implementationDirectoryLabel,DirectoryValue,EpochHash,VerifyResult,Digest) intoakd_traits, with backward-compatible aliases (AkdLabel,AkdValue) inakd_coreakd_traits(leaf) →akd_core→akdKeyDirectoryforakd::DirectoryBenchmarkSetuptrait + Criterion benchmarks)examples/scaling-bench) with database caching, sweep mode, and table/CSV/JSON output