fix(ci): enable anchor link validation in scheduled link checker#4604
Open
fix(ci): enable anchor link validation in scheduled link checker#4604
Conversation
Contributor
|
🌿 Preview your docs: https://fern-preview-jsklan-fix-broken-overrides-link.docs.buildwithfern.com/learn Here are the markdown pages you've updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a broken same-page anchor link in the overrides docs page, and updates the scheduled link checker to catch this class of bug going forward.
The link
[multiple override files](#multiple-override-files)pointed to a heading that doesn't exist — the correct anchor is#managing-overrides-across-apis. The scheduledcheck-links.ymlworkflow didn't catch this because it explicitly excluded anchor-only links (^#) and didn't validate HTML fragment targets.Context: The
^#exclusion and lack of--include-fragmentswere part of the original lychee setup in #2581, likely to avoid noise from fragments that couldn't be validated via HTTP. With--include-fragments, lychee now fetches each page and verifies that anchor targets exist asidattributes in the rendered HTML.Changes Made
#multiple-override-files→#managing-overrides-across-apis^#exclusion so anchor links are no longer skipped--include-fragmentsflag so lychee validates that anchor targets actually exist in rendered pagesTesting
check-links.ymlmanually viaworkflow_dispatchto verify anchor validation works