Implement BatchNormalization functions from cuDNN in juice#146
Draft
colepoirier wants to merge 1 commit intofff-rs:masterfrom
Draft
Implement BatchNormalization functions from cuDNN in juice#146colepoirier wants to merge 1 commit intofff-rs:masterfrom
colepoirier wants to merge 1 commit intofff-rs:masterfrom
Conversation
…i_batch_normalization_forward_training(), but now with a Result return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Closes #145.
Changes proposed by this PR:
Notes to reviewer:
I think that at least one additional new function https://docs.nvidia.com/deeplearning/cudnn/api/index.html#cudnnDeriveBNTensorDescriptor needs to be added in order to add the BatchNormalization functions to juice as: "This function derives a secondary tensor descriptor for the batch normalization scale, invVariance, bnBias, and bnScale subtensors from the layer's x data descriptor."
I am not sure how to proceed with this in terms of how to properly add this/implement it in rcudnn.
📜 Checklist
juice-examplesrun just fine