Skip to content

Scheduled sync: main → develop#1890

Merged
benflexcompute merged 1 commit intodevelopfrom
main
Mar 13, 2026
Merged

Scheduled sync: main → develop#1890
benflexcompute merged 1 commit intodevelopfrom
main

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 12, 2026

Automated sync needs review:

  • Merge conflicted: true
  • Direct push exit code: n/a
    Please resolve and merge to bring develop up to date with main.

Note

Medium Risk
Changes core meshing parameter validation and farfield-method inference, which can alter which configurations are accepted and how downstream meshing is configured.

Overview
Meshing validation now allows volume_zones to omit an explicit farfield zone when CustomZones contain CustomVolume entities, updating the error message to reflect the new requirement.

Farfield method inference is adjusted in both MeshingParams.farfield_method and ParamsValidationInfo._get_farfield_method_ to return user-defined when custom zones/seedpoint volumes are present without any farfield zone, and new tests cover the no-farfield custom-zones case plus a failure case requiring enclosed_entities when pairing explicit farfield types with custom volumes.

Written by Cursor Bugbot for commit 734186e. This will update automatically on new commits. Configure here.

@github-actions github-actions bot enabled auto-merge March 12, 2026 20:13
@benflexcompute benflexcompute merged commit 71c6b83 into develop Mar 13, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants