Scheduled sync: main → develop#1890
Merged
benflexcompute merged 1 commit intodevelopfrom Mar 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync needs review:
Please resolve and merge to bring
developup to date withmain.Note
Medium Risk
Changes core meshing parameter validation and farfield-method inference, which can alter which configurations are accepted and how downstream meshing is configured.
Overview
Meshing validation now allows
volume_zonesto omit an explicit farfield zone whenCustomZonescontainCustomVolumeentities, updating the error message to reflect the new requirement.Farfield method inference is adjusted in both
MeshingParams.farfield_methodandParamsValidationInfo._get_farfield_method_to returnuser-definedwhen custom zones/seedpoint volumes are present without any farfield zone, and new tests cover the no-farfield custom-zones case plus a failure case requiringenclosed_entitieswhen pairing explicit farfield types with custom volumes.Written by Cursor Bugbot for commit 734186e. This will update automatically on new commits. Configure here.