This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Skip the uploadtwice02 test on non-Windows systems #136
Closed
mapix wants to merge 1 commit intofohrloop:devfrom
Closed
Skip the uploadtwice02 test on non-Windows systems #136mapix wants to merge 1 commit intofohrloop:devfrom
mapix wants to merge 1 commit intofohrloop:devfrom
Conversation
… raises a locking error on Windows
This was referenced Aug 17, 2024
Owner
|
Would it make more sense to fix the test instead of skipping it? There must be a reason the And I fully support making contributions easier. As I just commented on the another PR, I feel that setting up the dev env is a bit difficult. If we can make the instructions easier to follow, that would be great! Edit: I see you've also mentioned this issue on your previous PR ( #130 ) |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
os.unlink()is non-blocking on Linux and macOS, uploadtwice02 may hinder contributions from developers on non-Windows platforms.