fix: bash 3.2 heredoc bug causes unbound variable on macOS install#21
Open
ruanwz wants to merge 1 commit intoforeveryh:mainfrom
Open
fix: bash 3.2 heredoc bug causes unbound variable on macOS install#21ruanwz wants to merge 1 commit intoforeveryh:mainfrom
ruanwz wants to merge 1 commit intoforeveryh:mainfrom
Conversation
macOS ships bash 3.2 which has a bug where `"$(cat <<'DELIM'...DELIM)"` incorrectly expands variables after a `case/esac` block inside the single-quoted heredoc. This caused `set -u` to trigger "account: unbound variable" during installation. Replace `content="$(cat <<'EOF'...EOF)"` with `IFS= read -r -d '' content <<'EOF' || true` in both write_ccm_wrapper and write_ccc_wrapper to avoid the command substitution entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./install.sh: line 702: account: unbound variableerror on macOS (bash 3.2)"$(cat <<'DELIM'...DELIM)"incorrectly expands variables after acase/esacblock inside a single-quoted heredoc, triggeringset -ucontent="$(cat <<'EOF'...EOF)"withIFS= read -r -d '' content <<'EOF' || truein bothwrite_ccm_wrapperandwrite_ccc_wrapperto avoid command substitution entirelyTest plan
bash -n install.shpasses syntax check./install.sh) completes without errorccmandcccwrappers contain correct content