Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Package(s)
@forward-software/react-auth(lib)@forward-software/react-auth-google(packages/google-signin)Related Issue(s)
Motivation
The Android module fails to compile because it references
GetGoogleIdTokenCredentialRequest, a class that does not exist in thecom.google.android.libraries.identity.googleid:googleid:1.1.1library. The correct class name isGetGoogleIdOption.Description of Changes
GetGoogleIdTokenCredentialRequestwithGetGoogleIdOptionsignInSilentlyto useGetGoogleIdOption.Builder()instead ofGetGoogleIdTokenCredentialRequest.Builder()getTokensto useGetGoogleIdOption.Builder()instead ofGetGoogleIdTokenCredentialRequest.Builder()Breaking Changes
None
How to Test
Vitest) and build steps pass successfully on this PR.pnpm installto install dependencies.pnpm --filter <affected-package> testto run tests for the affected package.pnpm --filter <affected-package> buildto verify the build succeeds.pnpm --filter <affected-package> lintto check for linting errors.signIn,signInSilently, andgetTokensfunctions on a device or emulator.Checklist
Notes for Reviewers
Single-file fix. The class
GetGoogleIdTokenCredentialRequestdoes not exist ingoogleid:1.1.1. The correct class provided by the library isGetGoogleIdOption, which serves the same purpose for requesting Google ID token credentials via the Android Credential Manager API.