Skip to content

fix: Android method renamed#227

Merged
IronTony merged 1 commit intomainfrom
fix/GoogleSigninAndroid
Mar 18, 2026
Merged

fix: Android method renamed#227
IronTony merged 1 commit intomainfrom
fix/GoogleSigninAndroid

Conversation

@IronTony
Copy link
Member

Affected Package(s)

  • @forward-software/react-auth (lib)
  • @forward-software/react-auth-google (packages/google-signin)
  • Examples
  • CI/CD / Repository configuration

Related Issue(s)

Motivation

The Android module fails to compile because it references GetGoogleIdTokenCredentialRequest, a class that does not exist in the com.google.android.libraries.identity.googleid:googleid:1.1.1 library. The correct class name is GetGoogleIdOption.

Description of Changes

  • Replaced import of GetGoogleIdTokenCredentialRequest with GetGoogleIdOption
  • Updated signInSilently to use GetGoogleIdOption.Builder() instead of GetGoogleIdTokenCredentialRequest.Builder()
  • Updated getTokens to use GetGoogleIdOption.Builder() instead of GetGoogleIdTokenCredentialRequest.Builder()

Breaking Changes

None

How to Test

  1. CI Checks: Verify that all automated tests (Vitest) and build steps pass successfully on this PR.
  2. Local Verification (Optional):
    • Run pnpm install to install dependencies.
    • Run pnpm --filter <affected-package> test to run tests for the affected package.
    • Run pnpm --filter <affected-package> build to verify the build succeeds.
    • Run pnpm --filter <affected-package> lint to check for linting errors.
  3. Android Verification:
    • Build the Android app and confirm compilation succeeds.
    • Test signIn, signInSilently, and getTokens functions on a device or emulator.

Checklist

  • My code follows the project's style guidelines
  • I have added or updated tests to cover the changes
  • I have updated relevant documentation
  • All tests are passing locally
  • CI checks are passing
  • I have reviewed my own code and lock file changes
  • I have checked for any potential security implications
  • I have verified the changes work as expected
  • My commit messages follow Conventional Commits format

Notes for Reviewers

Single-file fix. The class GetGoogleIdTokenCredentialRequest does not exist in googleid:1.1.1. The correct class provided by the library is GetGoogleIdOption, which serves the same purpose for requesting Google ID token credentials via the Android Credential Manager API.

@IronTony IronTony merged commit 2a485c9 into main Mar 18, 2026
12 checks passed
@IronTony IronTony deleted the fix/GoogleSigninAndroid branch March 18, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant