Conversation
|
The code of |
|
The |
|
There are plenty of submodules of git that needs to be downloaded and extracted before heading to |
|
Most of them could be replaced by the system dependencies without changes. The cmake script of eos seems clever enough. |
| src_prepare() { | ||
| default | ||
|
|
||
| cmake_src_prepare |
There was a problem hiding this comment.
Both default and cmake_src_prepare are going to try and apply any user patches. The second try will cause the build to fails since the patches are already applied. You can probably drop the entire explicit src_prepare phase.
|
|
||
| src_install() { | ||
| cmake_src_install | ||
| } |
There was a problem hiding this comment.
You don't have to set src_compile and src_install if you're only using the standard function.
| LICENSE="GPL-3" | ||
|
|
||
| SLOT="0" | ||
| KEYWORDS="~amd64" |
There was a problem hiding this comment.
Try to keep the layout as close to the ebuild skeleton as possible. (i.e. move LICENSE one line down)
| DEPEND="${RDEPEND}" | ||
|
|
||
| BDEPEND=" | ||
| dev-lang/python |
There was a problem hiding this comment.
If this requires python during build time, it should be inheriting python-any-r1.eclass and setting PYTHON_COMPAT to the supported python versions.
I think for
Lets use system versions whenever possible. |
3 participants
/etcdirectory.