[GraphHopper] Add provider parameter#1251
Open
bisleadity wants to merge 3 commits intogeocoder-php:masterfrom
Open
[GraphHopper] Add provider parameter#1251bisleadity wants to merge 3 commits intogeocoder-php:masterfrom
bisleadity wants to merge 3 commits intogeocoder-php:masterfrom
Conversation
jbelien
reviewed
Mar 21, 2025
Member
jbelien
left a comment
jbelien
left a comment
There was a problem hiding this comment.
This is a feature still in development.
The provider parameter is currently under development and can fall back to default at any time.
-- https://docs.graphhopper.com/openapi/geocoding/getgeocode#geocoding/getgeocode/t=request&in=query&path=provider
bisleadity
force-pushed
the
feature/graphhopper-add-provider
branch
from
8fedd22 to
4d66689
Compare
bisleadity
force-pushed
the
feature/graphhopper-add-provider
branch
from
0fbc0e1 to
320b5d7
Compare
Member
|
Could you maybe still add a real test? |
Author
|
What's a real test for you? |
Graphhopper geocoding supports different providers. Hereby the option is given to use those providers. # Conflicts: # src/Provider/GraphHopper/CHANGELOG.md
…aphHopper geocoding api Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers. [GraphHopper] Add GraphHopperProviders enum for provider options of GraphHopper geocoding api Graphhopper geocoding supports different providers. Hereby the option is given to use only available providers.
…ns of GraphHopper geocoding api" This reverts commit 320b5d7.
bisleadity
force-pushed
the
feature/graphhopper-add-provider
branch
from
676a401 to
ecb2707
Compare
|
hey @jbelien Could you elaborate on your "real test" requirement? I would love to have this feature too. |
Member
|
@bisleadity Sorry, I mean a test that makes a geocoding request on GraphHopper with the new Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graphhopper geocoding now supports different providers. Hereby the option is given to use those providers.
As we do need to use one of those providers and there was no possibility given so far I added it.