Skip to content

[msgpack] Fixes missing parameter comments, error message #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Mar 7, 2026
Merged

[msgpack] Fixes missing parameter comments, error message #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/rfl/msgpack/Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ Writer::OutputArrayType Writer::add_array_to_object(
}

Writer::OutputObjectType Writer::add_object_to_array(const size_t _size,
OutputArrayType*) const {
OutputArrayType* /*_parent*/) const {
return new_object(_size);
}

Writer::OutputObjectType Writer::add_object_to_object(
const std::string_view& _name, const size_t _size,
OutputObjectType*) const {
OutputObjectType* /*_parent*/) const {
auto err = msgpack_pack_str(pk_, _name.size());
if (err) {
throw std::runtime_error("Could not pack field name: '" +
Expand All @@ -66,7 +66,7 @@ Writer::OutputObjectType Writer::add_object_to_object(
return new_object(_size);
}

Writer::OutputVarType Writer::add_null_to_array(OutputArrayType*) const {
Writer::OutputVarType Writer::add_null_to_array(OutputArrayType* /*_parent*/) const {
const auto err = msgpack_pack_nil(pk_);
if (err) {
throw std::runtime_error("Could not add nil to array.");
Expand Down Expand Up @@ -110,7 +110,7 @@ Writer::OutputArrayType Writer::new_array(const size_t _size) const {
Writer::OutputObjectType Writer::new_object(const size_t _size) const {
const auto err = msgpack_pack_map(pk_, _size);
if (err) {
throw std::runtime_error("Could not pack array.");
throw std::runtime_error("Could not pack object.");
}
return OutputObjectType{};
}
Expand Down
Loading