Open
Conversation
4865158 to
53dd617
Compare
53dd617 to
822ed0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Summary
Migrates
@sentry/emberfrom the legacy v1 addon format to the Ember v2 addon format. This modernizes the package to work with both classic Ember builds and Embroider-optimized builds, and removes the runtime dependency on@embroider/macros.Changes
ember-clibuild pipeline withrollup(transpilation →dist/) +tsc(declarations →declarations/)addon-main.cjsusing@embroider/addon-shimas the addon entry pointember-addon.version: 2, updatedexportsmap, addedember-addon.app-jsmapping@embroider/macrosgetOwnConfig()with explicitSentry.init()calls and a newsetupPerformance()exportAPI changes:
init()is now called directly inapp.tsor an initializer (no moreENV['@sentry/ember']config)setupPerformance()must be called from an instance-initializer to opt into performance instrumentation<script>tags inindex.htmlUPGRADE.mdwith detailed migration guideTest & CI updates:
ember-classic,ember-embroider) to use v2 patterns:ENV['@sentry/ember']toSentry.init()inapp.ts<script>tags toindex.html.github/workflows/build.ymlCACHED_BUILD_PATHSfrompackages/ember/*.d.tstopackages/ember/dist+packages/ember/declarationsTypeScript fixes:
"types": ["ember-source/types"]totsconfig.publish.jsonfor Ember module resolution during declaration generation@ember/routing/-private/transition)instrumentFunctiongeneric to avoid tuple mismatch errorsBreaking Changes
ENV['@sentry/ember']config inconfig/environment.jsis no longer supported — useSentry.init()directlysetupPerformance()from an instance-initializer<script>tags inapp/index.htmlCloses #15835