Add options to the listReleases and listTags function#485
Add options to the listReleases and listTags function#485alexcanessa wants to merge 1 commit intogithub-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=========================================
Coverage ? 91.06%
=========================================
Files ? 12
Lines ? 403
Branches ? 0
=========================================
Hits ? 367
Misses ? 36
Partials ? 0
Continue to review full report at Codecov.
|
|
I'm wondering if there's maybe an alternative way to handle paging. This is going to be an issue with basically every get operation this library does. Would it be crazy to think about doing some sort of async iterables approach? The new What if we used generators and for people using callbacks, we just accumulated the result and returned that. For people using Promises, we could yield Promises until the results are done. It looks like @clayreimann Which browsers and versions does github-api support? |
|
Just adding options to most GETs would definitely work though. |
The request to get the list of releases and tags should have the options object in order to pass pagination options.
@see https://developer.github.com/v3/#pagination