C++: Make 'getChildCount' more robust by counting indices instead of elements

[MathiasVP]

In an ideal world counting elements should give the same as counting how many indices returns an element. However I noticed today that, on inconsistent databases, it is possible that a single index can return duplicated getDeclarationEntrys.

This meant that getChildCount() returned 2 (because there were two getDeclarationEntrys for index 0). However, only getDeclarationEntry(0) had a result (in fact it had 2 results), and getDeclarationEntry(1) returned no results. This caused the control-flow graph abruptly stop.

By changing getChildCount to count indices instead we avoid a dead-end in the control-flow graph since getChildCount() now returns 1.

[Copilot]

Pull request overview

This PR fixes a robustness issue in the C++ IR (Intermediate Representation) implementation where inconsistent databases could cause the control-flow graph to abruptly stop. The fix changes how getChildCount() calculates the number of children in declaration statements.

Changes:

• Modified TranslatedDeclStmt.getChildCount() to count distinct indices instead of counting elements, preventing issues when duplicate elements exist for a single index on inconsistent databases.

[IdrissRio]

LGTM 👍

DCA looks good as well except for one project failing with: fatal error occurred: Injecting Windows tracer failed which is completely unrelated.

[MathiasVP]

Thanks, Idriss! DCA looks fantastic. A not insignificant reduction in dead ends in the CFG across all projects.