Compare user and pass hashes simultaneously to avoid leaking if the username is valid#23
Open
nvx wants to merge 2 commits intogoji:masterfrom
Open
Compare user and pass hashes simultaneously to avoid leaking if the username is valid#23nvx wants to merge 2 commits intogoji:masterfrom
nvx wants to merge 2 commits intogoji:masterfrom
Conversation
username is correct but not the password via a timing side channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the user and pass hashes are compared separately, if the username matches but not the password the middleware will return slightly faster than if both the username and password are wrong.
This change concatenates the user and pass hashes together and compares them in one call to
subtle.ConstantTimeCompareremoving any timing leaks.I also added a go.mod file.