Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and valuable refactoring by creating the A2uiSchemaManager to centralize schema loading, management, and prompt generation. This makes the system more robust and easier to extend. The use of build hooks to package schema files and the clear separation of concerns in the new inference package are excellent design choices. However, I've identified a few issues, including a critical one where validation is disabled in one of the samples, which should be addressed before merging.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
f398270 to
6bb60e0
Compare
6bb60e0 to
f350823
Compare
f350823 to
9e911d4
Compare
9e911d4 to
f9e0676
Compare
ca42830 to
b70d611
Compare
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK. Tested: - [x] The `rizzcharts` Angular client successfully connected to the `rizzcharts` agent and rendered the response correctly.
b70d611 to
941058f
Compare
|
It includes the following changes:
Follow up:
|
Summary of ChangesThis pull request overhauls the A2UI schema handling within the Python SDK, centralizing schema management, validation, and payload fixing into dedicated classes. This change aims to improve the reliability and maintainability of A2UI integrations by providing a more structured and robust framework for defining and validating UI components and data. The Highlights
Changelog
|
Description
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK.
Tested:
rizzchartsAngular client successfully connected to therizzchartsagent and rendered the response correctly.rizzcharts_demo.mov
orchestatorAngular client successfully connected to theorchestatoragent and all subagents.orchestrator_demo.mov
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.