-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Address gen-iterators review feedback
#3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Glenn Lewis <[email protected]>
gen-iterators review feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
GitHub Actions is currently having issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
+ Coverage 85.51% 93.60% +8.09%
==========================================
Files 204 204
Lines 17554 17411 -143
==========================================
+ Hits 15011 16298 +1287
+ Misses 1913 912 -1001
+ Partials 630 201 -429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Glenn Lewis <[email protected]>
@alexandear - the new test coverage for |
Signed-off-by: Glenn Lewis <[email protected]>
|
Thank you, @alexandear - I believe I've addressed your review feedback. |
|
@gmlewis LGTM |
Co-authored-by: Oleksandr Redko <[email protected]>
|
Thank you, @alexandear! |
|
@gmlewis - LGTM. |

Follow-up to: #3916.
cc: @alexandear - @Not-Dhananjay-Mishra - @merchantmoh-debug