Skip to content

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 2, 2026

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Feb 2, 2026
@gmlewis gmlewis changed the title chore: Address gen-iterators review feedback chore: Address gen-iterators review feedback Feb 2, 2026
Copy link
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should improve the generation of the github-iterators_test.go. Because currently, a lot of lines are not covered by unit tests:

image

@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 2, 2026

GitHub Actions is currently having issues:
https://www.githubstatus.com/
Hopefully this will be resolved soon.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (91d01f7) to head (a3597ee).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3962      +/-   ##
==========================================
+ Coverage   85.51%   93.60%   +8.09%     
==========================================
  Files         204      204              
  Lines       17554    17411     -143     
==========================================
+ Hits        15011    16298    +1287     
+ Misses       1913      912    -1001     
+ Partials      630      201     -429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 3, 2026

We should improve the generation of the github-iterators_test.go. Because currently, a lot of lines are not covered by unit tests:

@alexandear - the new test coverage for github-iterators.go is 100%.
I believe I've addressed all your feedback. Please take another look when you get a chance.

Signed-off-by: Glenn Lewis <[email protected]>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 3, 2026

Thank you, @alexandear - I believe I've addressed your review feedback.
Please take another look when you have a chance.

@alexandear
Copy link
Contributor

@gmlewis LGTM

Co-authored-by: Oleksandr Redko <[email protected]>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Feb 3, 2026

Thank you, @alexandear!
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 3, 2026
@merchantmoh-debug
Copy link
Contributor

@gmlewis - LGTM.

@gmlewis gmlewis merged commit 57c6268 into google:master Feb 3, 2026
8 checks passed
@gmlewis gmlewis deleted the pr3916-continuation branch February 3, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants