Open
Conversation
Fixes google#95. Canvas text rendering was hardcoded to textAlign='center' and textBaseline='middle', ignoring the configured properties. Now uses this.textAlign for horizontal alignment and maps this.anchorY to the correct canvas textBaseline and draw position.
Adds vitest + jsdom as test infrastructure. Includes tests verifying that canvas-based text rendering respects the textAlign and anchorY properties instead of hardcoding center alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95
The canvas text fallback was hardcoded to
textAlign='center'andtextBaseline='middle', ignoring the properties that SDF text handles correctly. Now maps textAlign to the correct draw X position and anchorY to the matching textBaseline and draw Y.Similar to #202 I've added a test harness setup, but we can probably rebase after whichever is merged in first.
Test harness issue: #205