Skip to content

Removed rule splitting#1992

Open
jessevz wants to merge 3 commits intodevfrom
705-enhancement-remove-rule-splitting
Open

Removed rule splitting#1992
jessevz wants to merge 3 commits intodevfrom
705-enhancement-remove-rule-splitting

Conversation

@jessevz
Copy link
Contributor

@jessevz jessevz commented Mar 17, 2026

closes #705

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy “rule splitting” feature by deleting the associated server-side logic and retiring the related configuration options, with DB migrations to clean up existing config rows.

Changes:

  • Added MySQL and Postgres migrations to delete ruleSplit* config entries.
  • Removed TaskUtils::splitByRules() and the benchmark-triggered rule-splitting path in APISendBenchmark.
  • Removed RULE_SPLIT_* options from DConfig config type/description mappings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/migrations/postgres/20260317120000_remove-rule-split.sql Deletes legacy ruleSplit* config rows in Postgres.
src/migrations/mysql/20260317120000_remove-rule-split.sql Deletes legacy ruleSplit* config rows in MySQL.
src/inc/utils/TaskUtils.php Removes the task splitting-by-rules implementation.
src/inc/defines/DConfig.php Removes rule-split config options from type/description mappings.
src/inc/api/APISendBenchmark.php Removes auto rule-splitting triggered by benchmark submission.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@jessevz jessevz requested a review from s3inlc March 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants