Create github CODEOWNERS for core maintainer HIP management#369
Open
Create github CODEOWNERS for core maintainer HIP management#369
Conversation
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
gjenkins8
commented
Nov 11, 2024
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
gjenkins8
commented
Nov 11, 2024
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
gjenkins8
commented
Nov 11, 2024
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
scottrigby
requested changes
May 21, 2025
Member
scottrigby
left a comment
There was a problem hiding this comment.
Great work George.
Though I agree most HIPs are for Helm core, HIPs can and sometimes are proposals for other areas of the Helm project. hip-0001 makes clear who can approve a HIP:
The final authority for proposal approval is the project maintainers responsible for the project the proposal is aimed at
I do think this is an improvement, though I would just ask that Helm core maintainers bear in mind when a proposal is meant for another area of the Helm project.
Can you update this repo's CONTRIBUTING.md in this PR with the proposed changes including clarifying this note above so the process is clear?
To-do after merging:
- Once this PR merges, we will need to give @helm/helm-core-maintainers write access to this repo for this PR to have any effect.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@helm/helm-org-maintainersdefault owner@helm/helm-org-maintainersand@helm/helm-core-maintainers(either may approve) forhips/dir@helm/helm-org-maintainersremainsCODEOWNERSowner(for the
CODEOWNERSto be fully valid,@helm/helm-core-maintainersneeds to be added for write access; currently it does not)