Open
Conversation
Author
|
@becarpenter might have some test cases to add. |
|
I don't have context to know what sort of test cases you would want. There are examples in draft-ietf-6man-rfc6874bis. |
a1bce4d to
23507ef
Compare
23507ef to
2d486c5
Compare
2d486c5 to
e0ca6fb
Compare
e0ca6fb to
2f70789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to create an authority object from a SocketAddr.
While many web interactions start with a URL, there are others that start from a mDNS, DNS-SD or GRASP (RFC8990) discovery. IP addresses (often link-local), port numbers (and IPv6 scope) are returned from the discovery, but one then needs to form a URI for the relevant HTTP library.
(Although the application usually has to open the socket itself, a URI is often still required for Host: header, and path+query string)
Perhaps this should be hidden behind some feature to avoid a dependency upon net.
Probably this should also be behind no_std, since byte strings are created.
I was surprised that the URI was not parsed into pieces and pointed to separately, but I see the logic for this.
I would prefer to put this into authority because that keeps the knowledge about what are valid and invalid URIs in one place.
(Thank you, btw, for supporting RFC6874, and note draft-ietf-6man-rfc6874bis/ about to be published)