Skip to content

[INSTA-69727] Fysom improvement for multi-threaded operations#832

Open
CagriYonca wants to merge 1 commit intomainfrom
fix-gunicorn
Open

[INSTA-69727] Fysom improvement for multi-threaded operations#832
CagriYonca wants to merge 1 commit intomainfrom
fix-gunicorn

Conversation

@CagriYonca
Copy link
Contributor

  • The state machine was not compatible with multi-threads by default. Every fork was changing the state of the fysom so that Fysom was falling into fysom.FysomError: event announce inappropriate in current state announced error. After adding a thread-safe lock mechanism, it works and propagates spans as expected.
  • Verified that the instrumentation works even without hooks.

@CagriYonca CagriYonca self-assigned this Jan 7, 2026
@CagriYonca CagriYonca requested a review from a team as a code owner January 7, 2026 09:57
@CagriYonca CagriYonca added the bug label Jan 7, 2026
@CagriYonca CagriYonca changed the title Gunicorn INSTA-69727 - Fysom improvement for multi-threaded operations Jan 7, 2026
@CagriYonca
Copy link
Contributor Author

The code is tested for gunicorn in amd64, arm64 and with autotrace-webhook.

@CagriYonca CagriYonca changed the title INSTA-69727 - Fysom improvement for multi-threaded operations [INSTA-69727] Fysom improvement for multi-threaded operations Jan 12, 2026
@CagriYonca CagriYonca force-pushed the fix-gunicorn branch 3 times, most recently from e57efa4 to 8970564 Compare January 16, 2026 08:46
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes.

…nstrumentation

Signed-off-by: Cagri Yonca <cagri@ibm.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants