Contact & Conversation Tagging / Articles / Messages by MCKLtech · Pull Request #314 · intercom/intercom-php

MCKLtech · 2020-09-02T15:32:30Z

Why?

Added Articles endpoint
Added Contact Tagging
Added Conversation Tagging
Added additional Messages endpoints including Exports

How?

N/A

- Added Conversation Tagging - Minor bug fixes

GabrielAnca

Thank you so much for this @MCKLtech, we really appreciate that you're taking the time to bring all these endpoints to the SDK! 🚀 I made some minor comments on the PR, but this is going in a great direction!

Apart from the comments, we'd need to update the README file and write tests for all these new methods too 😃

GabrielAnca · 2020-09-02T15:35:14Z

src/IntercomArticles.php

+     * Updates an existing Article
+     *
+     * @see    https://developers.intercom.com/intercom-api-reference/v0/reference#update-an-article
+     * @param  array $options


I´m missing the phpdoc for @param $id

Adding Fix.

GabrielAnca · 2020-09-02T15:37:58Z

src/IntercomContacts.php

     *
     * @see    https://developers.intercom.com/intercom-api-reference/reference#update-contact
     * @param  string $id
+     * Updates an existing Contact


It seems these lines are a bit off 😅

Woops. Fixing

GabrielAnca · 2020-09-02T15:38:21Z

src/IntercomContacts.php

     */
-    public function getContact(string $id, array $options = [])
+
+    public function getContact($id, $options = [])


Why are we removing the strong typing here?

Suggested change

public function getContact($id, $options = [])

public function getContact(string $id, array $options = [])

My bad. I think when I merged the change my version was included which wasn't typed. Fixed.

GabrielAnca · 2020-09-02T15:38:41Z

src/IntercomArticles.php

+     * @return stdClass
+     * @throws Exception
+     */
+    public function getArticle($id, $options = [])


I would prefer all the new methods to be strongly typed

Suggested change

public function getArticle($id, $options = [])

public function getArticle(string $id, array $options = [])

Same for the rest of the methods in this file

GabrielAnca · 2020-09-02T15:39:49Z

src/IntercomContacts.php

+     *
+     * @see    https://developers.intercom.com/intercom-api-reference/reference#tag-contact
+     * @param  string $id
+     * @param  string  $tag_id


We should use camelCase for all variables in this repo 🙌

Suggested change

* @param string $tag_id

* @param string $tagId

WeCanCertainlyDoThat.

Fixed.

GabrielAnca · 2020-09-02T15:40:41Z

src/IntercomContacts.php

+     */
+    public function addTag(string $id, string $tag_id)
+    {
+        $path = $this->contactPath($id);


I think it would be cleaner if we create a contactTagsPath method in this class, what do you think?

Good call, adding now.

GabrielAnca · 2020-09-02T15:42:31Z

src/IntercomMessages.php

    {
        return $this->client->post("messages", $options);
    }
+


The message export feature is on the Unstable version at the moment and is subject to changes, so I am not sure if we want to add something not stable to the SDK 🤔 @mmartinic @murtron what do you think?

Agreed. We actually use it in a production system at the moment hence why we built it.

Move to a beta branch or something?

- Updated Readme (Contacts & Articles) - Fixed strong typing - Various fixes as per pull/314

- Duplicated Contacts declaration

- Removed IntercomCustomers

GabrielAnca · 2020-10-06T12:40:08Z

README.md

+
+```php
+/** Create an Article */
+$client->articles->create(["title" => "How To Use the Intercom API", "description" => "A quick guide to the universe of the Intercom API", "body" => "<p>This is the body in html</p>", "author_id" => 1]);


Would love to split this into multiple lines:

Suggested change

$client->articles->create(["title" => "How To Use the Intercom API", "description" => "A quick guide to the universe of the Intercom API", "body" => "This is the body in html", "author_id" => 1]);

$client->articles->create([

"title" => "How To Use the Intercom API",

"description" => "A quick guide to the universe of the Intercom API",

"body" => "This is the body in html",

"author_id" => 1,

]);

GabrielAnca · 2020-10-06T12:40:52Z

README.md

+$client->articles->getArticle("123456");
+
+/** Update an Article */
+$client->articles->update("123456", ["title" => "How To Use the Intercom API", "description" => "A quick guide to the universe of the Intercom API", "body" => "<p>This is the body in html</p>");


Same here 😃

Suggested change

$client->articles->update("123456", ["title" => "How To Use the Intercom API", "description" => "A quick guide to the universe of the Intercom API", "body" => "This is the body in html");

$client->articles->update(

"123456",

[

"title" => "How To Use the Intercom API",

"description" => "A quick guide to the universe of the Intercom API",

"body" => "This is the body in html",

]

);

GabrielAnca · 2020-10-06T12:43:12Z

src/IntercomClient.php

+    /**
+     * @var IntercomCustomers $customers
+     */
+    //public $customers;


I know this is work in progress, but wanted to add a reminder that this and its initializer are commented out 😄

- Added getAttributes to Contacts

harrisbp · 2020-12-03T17:50:54Z

Is this PR going to be merged anytime soon?

GabrielAnca · 2020-12-03T18:29:21Z

This PR is getting very good shape! @MCKLtech do you have time to work on finishing this one? Otherwise, I'm happy to jump in and finish the last bits.

marijnbent · 2021-01-23T19:30:58Z

Any progress on this PR @GabrielAnca ?

MCKLtech · 2021-01-23T22:54:18Z

I'm not going to have time to write tests etc for this in the next few weeks so I'll need someone else to pick up that torch for now.

MCKLtech · 2021-02-10T15:28:21Z

@GabrielAnca any chance this, and other PRs, could be escalated internally at Intercom?

- Added Listing for Tags, Segments & Companies

Colin Longworth added 30 commits March 10, 2020 10:56

Added Contacts & Messages endpoints

8a5d433

Fixed URLs for messages

12cf8ae

Fixes for messages end point

42b9d6a

Conversation Search

19a20b3

Companies

8f34502

Contact Attributes

0d972de

Contacts Search

b0a1b61

fixed contact update method

2b613bd

Contact update fix

cbb6bab

Added Articles

d52084e

Update IntercomArticles.php

c752909

Added tag options for contacts

966ab4a

Contact tag fix

3adef45

Added Contacts & Messages endpoints

c73965c

Fixed URLs for messages

9a1fdea

Fixes for messages end point

074574f

Conversation Search

217e059

Companies

64a24e5

Contact Attributes

ef7029e

Contacts Search

ddda8f6

fixed contact update method

760ffca

Contact update fix

494c770

Added Articles

7c5bc59

Update IntercomArticles.php

5a1d17f

Added tag options for contacts

52a8dab

Contact tag fix

f748109

Update IntercomContacts.php

eaa8f78

Added Contact Tagging

de1ed0d

Updated Doc URLs

fd620d1

Various changes

e8fc1be

- Added Conversation Tagging - Minor bug fixes

MCKLtech mentioned this pull request Sep 2, 2020

Contacts Resource - Missing Tag Functionality #313

Open

GabrielAnca reviewed Sep 2, 2020

View reviewed changes

Colin Longworth and others added 3 commits September 10, 2020 15:06

Fixes for pull/314

027baf1

- Updated Readme (Contacts & Articles) - Fixed strong typing - Various fixes as per pull/314

Update IntercomClient.php

484a7d8

- Duplicated Contacts declaration

Update IntercomClient.php

14f8bfa

- Removed IntercomCustomers

GabrielAnca reviewed Oct 6, 2020

View reviewed changes

Update IntercomContacts.php

af555c6

- Added getAttributes to Contacts

Colin Longworth added 2 commits February 24, 2021 09:18

Added Data Attribute End Points

d5ca224

Update IntercomContacts.php

2bd694d

- Added Listing for Tags, Segments & Companies

	public function getContact($id, $options = [])
	public function getContact(string $id, array $options = [])

	public function getArticle($id, $options = [])
	public function getArticle(string $id, array $options = [])

Conversation

MCKLtech commented Sep 2, 2020

Why?

How?

Uh oh!

GabrielAnca left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GabrielAnca Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harrisbp commented Dec 3, 2020

Uh oh!

GabrielAnca commented Dec 3, 2020

Uh oh!

marijnbent commented Jan 23, 2021

Uh oh!

MCKLtech commented Jan 23, 2021

Uh oh!

MCKLtech commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GabrielAnca Sep 2, 2020 •

edited

Loading