fix: open card link in new tab using target _blank by Tushar8466 · Pull Request #2299 · json-schema-org/website

Tushar8466 · 2026-03-01T13:54:44Z

What kind of change does this PR introduce?
Bug fix — external links were opening in the same tab instead of a new tab.

What does this PR do?
Added target="_blank" and rel="noopener noreferrer" to all external anchor
tags so they open in a new browser tab without navigating the user away from
the current page.

Checklist

I have tested the changes locally
External links now open in a new tab
No existing functionality is broken
rel="noopener noreferrer" added for security

github-actions · 2026-03-01T13:54:53Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference, kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copilot

Pull request overview

This PR aims to ensure external links open in a new browser tab (with rel="noopener noreferrer") so users don’t navigate away from the current page.

Changes:

Added target="_blank" to a couple of external <a> links on the home page.
Updated the shared Card component to render its link with target="_blank" and rel="noopener noreferrer".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
pages/index.page.tsx	Adds `target="_blank"` to two GitHub discussion links on the home page.
components/Card.tsx	Makes all `Card` links open in a new tab by default and adds `rel` for security.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-01T13:57:16Z

components/Card.tsx

+    <Link
+      href={link}
+      target="_blank"
+      rel="noopener noreferrer"
+      data-test="card-link"
+    >


Card now forces every linked card (including internal routes like /learn/...) to open in a new tab via target='_blank'. This changes in-app navigation behavior and conflicts with the PR description (external links only). Consider applying target/rel only for external URLs (e.g., http(s)://) or making this behavior configurable via a prop.

Copilot · 2026-03-01T13:57:16Z

components/Card.tsx

+      target="_blank"
+      rel="noopener noreferrer"
+      data-test="card-link"


This JSX uses double quotes (target="_blank", rel="...", data-test="...") while the repo Prettier config enforces jsxSingleQuote: true. Using single quotes here will avoid formatting churn / potential CI failures.

Suggested change

target="_blank"

rel="noopener noreferrer"

data-test="card-link"

target='_blank'

rel='noopener noreferrer'

data-test='card-link'

Copilot · 2026-03-01T13:57:17Z

components/Card.tsx

+    <Link
+      href={link}
+      target="_blank"
+      rel="noopener noreferrer"
+      data-test="card-link"
+    >
      <CardBody link={link} {...props} />
    </Link>


There are existing Cypress component tests for Card (e.g., cypress/components/Card.cy.tsx asserts the rendered link). Since this change adds target/rel behavior (and ideally should vary by internal vs external URLs), please add/adjust tests to assert the new attributes and guard against regressions.

Copilot · 2026-03-01T13:57:17Z

pages/index.page.tsx

                  <a
                    href='https://github.com/orgs/json-schema-org/discussions/35'
-                    rel='noopener noreferrer'
+                    rel='noopener noreferrer' target='_blank'
                    className='max-w-[300px] w-full text-center rounded border-2 bg-primary hover:bg-blue-700 transition-all duration-300 ease-in-out text-white h-[40px] mb-4 flex items-center justify-center mx-auto dark:border-none'
                  >


PR description says "Added target=_blank ... to all external links", but this file still contains external anchors without target/rel (e.g., the Landscape link at ~lines 240-245). Either update the remaining external links for consistency or narrow the PR description/scope.

Utkarsh-123github · 2026-03-01T15:53:37Z

Hi @Tushar8466
Your PR is having conflicts, please resolve those.
Thanks!

github-actions · 2026-03-01T17:11:39Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
website	✅ Ready (View Log)	Visit Preview	`0584212`

codecov · 2026-03-01T17:14:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4bd72bb) to head (0584212).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #2299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          672       672           
  Branches       211       211           
=========================================
  Hits           672       672

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Tushar8466 · 2026-03-01T17:22:19Z

Hi @Utkarsh-123github, I've successfully resolved all the merge conflicts. The branch is now clean and ready for your review. Please take a look when you get a chance!

Utkarsh-123github

Hi @Tushar8466 , on clicking Join Slack button, it is opening in the same tab.
Please fix this whenever you get time.
Thanks !

Tushar8466 · 2026-03-03T07:58:31Z

@Utkarsh-123github I have addressed all the requested changes. Here's a summary of what was fixed:

✅ Added rel="noreferrer" to the target="_blank" anchor tag to resolve the security vulnerability
✅ Fixed the Prettier formatting issue on line 414 to meet the project's code style standards
✅ Build and lint checks are now passing successfully

Tushar8466 · 2026-03-05T19:55:57Z

@Utkarsh-123github I have made the changes you were asking for

fix: open card link in new tab using target _blank

e632a30

Copilot AI review requested due to automatic review settings March 1, 2026 13:54

Tushar8466 requested a review from a team as a code owner March 1, 2026 13:54

github-project-automation bot added this to PR - Triage Group Mar 1, 2026

github-project-automation bot moved this to Ready to review in PR - Triage Group Mar 1, 2026

github-actions bot added the needs-info label Mar 1, 2026

Copilot started reviewing on behalf of Tushar8466 March 1, 2026 13:55 View session

github-actions bot removed the needs-info label Mar 1, 2026

Copilot AI reviewed Mar 1, 2026

View reviewed changes

Tushar8466 added 2 commits March 1, 2026 22:32

Merge branch 'main' into fix/open-link-in-new-tab

44b4bad

fix: eslint and prettier issues

6d0066f

github-actions bot deployed to Preview March 1, 2026 17:11 View deployment

This was referenced Mar 2, 2026

🐛 Bug: External link opens in the same tab instead of a new tab #2249

Closed

🐛 Bug: External link opens in the same tab instead of a new tab #2252

Closed

Utkarsh-123github requested changes Mar 3, 2026

View reviewed changes

github-project-automation bot moved this from Ready to review to Changes requested in PR - Triage Group Mar 3, 2026

Tushar8466 added 3 commits March 3, 2026 12:58

fix: open slack link in new tab

e0266fc

fix: open slack link in new tab

762f2c8

fix: open slack link in new tab

0584212

github-actions bot deployed to Preview March 3, 2026 07:54 View deployment

Uh oh!

Conversation

Tushar8466 commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Utkarsh-123github commented Mar 1, 2026

Uh oh!

github-actions bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Uh oh!

codecov bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Tushar8466 commented Mar 1, 2026

Uh oh!

Utkarsh-123github left a comment

Choose a reason for hiding this comment

Uh oh!

Tushar8466 commented Mar 3, 2026

Uh oh!

Tushar8466 commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tushar8466 commented Mar 1, 2026 •

edited

Loading

github-actions bot commented Mar 1, 2026 •

edited

Loading

codecov bot commented Mar 1, 2026 •

edited

Loading