Added --input-file-encoding as a command line argument#10
Open
JohanNorberg wants to merge 1 commit intokarpathy:masterfrom
Open
Added --input-file-encoding as a command line argument#10JohanNorberg wants to merge 1 commit intokarpathy:masterfrom
JohanNorberg wants to merge 1 commit intokarpathy:masterfrom
Conversation
|
I agree. The first thing I did when experimenting with makemore was adding that option to let it generate French words. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to train the program on making more Swedish names. They contain special characters like Å and Ö, so I need to read the file using utf-8. On windows (at least on my machine) this is a problem since default encoding is cp1252, so it doesn't work. So I added a command line argument so I can specify the encoding.
Wrong
python .\makemore.py -i .\swe_names.txt -o swe_namesCorrect
python .\makemore.py -i .\swe_names.txt -o swe_names --input-file-encoding utf-8swe_names.txt
Btw, watching all of your videos on YT, they are great!