Open
Conversation
Allow unauthorized pullImageCmd
* Removes transitive dep on groovy-all
Remove Google Guava as dependency
Update to latest unix-socket-factory
Added missing @OverRide tags.
Patched LoggingFilter to work with CXF.
Multiple volumesFrom option when creating a container
Fix Issue #139
from commands. Create representations for them. Signed-off-by: Nigel Magnay <[email protected]>
over in a typed fashion so that clients can read out the responses. Use Iterable so the response does not have to be 'complete' before consuming. Derive from InputStream to maintain backwards compatibility and for clients that don't want to parse the response. Signed-off-by: Nigel Magnay <[email protected]>
Signed-off-by: Nigel Magnay <[email protected]>
Signed-off-by: Nigel Magnay <[email protected]>
…re all set Unless this is done, it is possible to create an invalid AuthConfig with null values for password and other fields.
Only override AuthConfig iff username/password/email/server address are ...
Utility classes and streamed JSON representations
It the callback decideds it is no longer interested in receiving events whilst it handles either an event or an exception then it should not have to wait until the next event from Docker is received to exit the loop. This adds a check before the event is received and leaves the check after the event has received as the event may take a long time to come and the callback may have decided during that time that it wants to shutdown.
Do not wait for another event before exiting.
…to NirmataOSS-master
Labels are array of Strings (fixes #232)
Fix volumesFrom
…nto imagenames Started Implementing jgriffiths1993/docker-java DockerImageName-solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've taking jgriffiths1993's DockerImageName and tried to implement it in all Commands that use it. The unit-tests succeed.
It might need more real testing.