Fix layout issue with title font sizing in attributed strings#30
Open
FelixLisczyk wants to merge 1 commit intolascic:mainfrom
Open
Fix layout issue with title font sizing in attributed strings#30FelixLisczyk wants to merge 1 commit intolascic:mainfrom
FelixLisczyk wants to merge 1 commit intolascic:mainfrom
Conversation
Contributor
Author
|
@lascic Any updates on this PR? Were you able to reproduce the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical bug where title labels (icon and "Welcome to" text) were rendering at approximately 1/4 screen size on iPad when using attributed strings without explicit font attributes.
Problem
The
updateFontSize(_:)method inUIOnboardingTitleLabelwas calculating font size multipliers incorrectly when attributed strings didn't have font attributes pre-set. This caused the title labels to render at the wrong size on iPad.Root Cause
The original implementation (from PR #27) captured
originalFont = fontbefore updating the label's font property, then used this stale value to calculate multipliers. When attributed strings had no font attributes set, the multiplier calculation would use mismatched font sizes, resulting in incorrect rendering.Additionally, the method only updated fonts that were already present in the attributed string, leaving ranges without font attributes unstyled.
Solution
Updated
updateFontSize(_:)to:self.fontto the target size before any calculationsScreenshots
Before
After