hub changes for stream/repost with extensions#113
Open
moodyjon wants to merge 13 commits intolbryio:masterfrom
Open
hub changes for stream/repost with extensions#113moodyjon wants to merge 13 commits intolbryio:masterfrom
moodyjon wants to merge 13 commits intolbryio:masterfrom
Conversation
moodyjon
commented
Nov 15, 2022
Contributor
Author
|
The point of commit 5b1d4bf Is to cut off indexing of all the nested things inside extensions. The fields which are “runtime” can be queried, but not as time-efficiently as others. So you can find extension “cad” quickly because they are indexed, but query on fields like “cad.foo” are evaluated more slowly. |
Rest of extension content is considered a "runtime" field.
moodyjon
force-pushed
the
limited_repost
branch
from
199dee9 to
806b29c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: lbryio/lbry-sdk#3706
Not sure that the query for extensions works as well as I would like.
Also I plan to look into some of the options for limiting how many fields, and how deep the indexing of fields within extensions goes:
https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-settings-limit.html