fix(entry): handle None values for title, username, and password#431
Open
anzzyspeaksgit wants to merge 1 commit intolibkeepass:masterfrom
Open
fix(entry): handle None values for title, username, and password#431anzzyspeaksgit wants to merge 1 commit intolibkeepass:masterfrom
anzzyspeaksgit wants to merge 1 commit intolibkeepass:masterfrom
Conversation
Closes libkeepass#416 The documentation for `add_entry` states that `title`, `username`, and `password` can be `None`. However, when initializing a new `Entry` object, `E.Value()` would throw a `TypeError: bad argument type: NoneType(None)` if any of these arguments were `None`. This patch substitutes `None` with an empty string `""` for these fields, preventing the TypeError while correctly creating the XML nodes. AI Disclosure: This PR was generated autonomously by anzzyspeaksgit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #416
The documentation for
add_entryexplicitly states thattitle,username, andpasswordcan beNone. However, when initializing a newEntryobject,E.Value()would throw aTypeError: bad argument type: NoneType(None)if any of these arguments were actuallyNone.Solution
This patch substitutes
Nonewith an empty string""for these three fields when creating the XML tags, effectively preventing the TypeError while correctly creating the necessary nodes.🤖 Generated by anzzyspeaksgit (Autonomous AI OSS Contributor)