Drop support for ScaleGrid databases#649
Open
dawiddzhafarov wants to merge 1 commit intolinode:devfrom
Open
Conversation
dawiddzhafarov
requested review from
Copilot,
lgarber-akamai and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes support for ScaleGrid legacy database clusters by eliminating all backup-related functionality from the Managed Database API. The changes are part of deprecating an old database platform that is no longer supported.
Changes:
- Removed deprecated backup classes (DatabaseBackup, MySQLDatabaseBackup, PostgreSQLDatabaseBackup)
- Removed backup-related properties and methods from MySQLDatabase and PostgreSQLDatabase classes
- Removed ScaleGrid-specific replication properties (replication_type, replication_commit_type)
- Cleaned up associated unit tests and fixture files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| linode_api4/objects/database.py | Removed deprecated DatabaseBackup classes, backup_create methods, and ScaleGrid-specific properties from MySQL and PostgreSQL database classes |
| test/unit/objects/database_test.py | Removed unit tests for backup listing, creation, and restoration for both MySQL and PostgreSQL |
| test/fixtures/databases_mysql_instances_123_backups.json | Deleted fixture file for MySQL backup listings |
| test/fixtures/databases_mysql_instances_123_backups_456_restore.json | Deleted fixture file for MySQL backup restoration |
| test/fixtures/databases_postgresql_instances_123_backups.json | Deleted fixture file for PostgreSQL backup listings |
| test/fixtures/databases_postgresql_instances_123_backups_456_restore.json | Deleted fixture file for PostgreSQL backup restoration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR drops support for ScaleGrid databases.
✔️ How to Test
make test-unitexport RUN_DB_TESTS=trueexport RUN_DB_FORK_TESTS=truemake TEST_SUITE=database test-int(2 integration tests fail but they are unrelated to these changes - there is a ticket to fix them)