magento/magento2#38154: Getting success message after sending invalid SKU for the inventory/source-items API

[MaximLogic]

Description (*)

According to issue magento/magento2#38154, the /rest/V1/inventory/source-items POST API endpoint was accepting requests with non-existent SKUs and returning 200 OK status code without any validation errors. In Inventory\Model\SourceItem\Validator\SkuValidator, validation only checked if SKU is not empty and doesn't have leading/trailing spaces, but didn't verify if a product with that SKU actually exists in the catalog.

I've added validateSkuExists() method into Inventory\Model\SourceItem\Validator\SkuValidator, that tries to load product by given SKU,and in case of failure, it catches NoSuchEntityException and returns validation error "Product with SKU <given_sku> does not exist."

Fixed Issues (if relevant)

1. Fixes Getting success message after sending invalid SKU for the inventory/source-items API magento2#38154

Prerequisites: Have Magento installed with magento/inventory-metapackage and at least one product in store (e.g., SKU "24-MB01")

Manual testing scenarios (*)

1. Get API token:

   curl --location 'http://your-magento.local/rest/V1/integration/admin/token' \
   --header 'Content-Type: application/json' \
   --data '{"username":"admin","password":"your-password"}'
   

2. Test with non-existent SKU:

Expected result: API returns 400 Bad Request status, Error message:
{"message":"Validation Failed","errors":[{"message":"Product with SKU \"sfasdfasd\" does not exist.","parameters":[]}]}

3. Test with existing SKU:

Expected result: API returns 200 OK, Source item quantity is updated successfully

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @MaximLogic,

Thank your for the contribution!

Please refer to the below review comments.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Thank you @MaximLogic for making the changes!

It seems some automated tests are failing due to the PR changes, please fix those.