Open
Conversation
Contributor
Author
|
Okay, even I have reverted the changes I have reverted the changes done to the Looks like it also happened at #50. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know it's quit a bold PR, but I think it's important to also support non monotonic options like other
ULIDlibraries for example:NUlid.ULIDC++ implementation.ULIDJS implementation.I needed to refactor a little to make it work, but the behavior has not been broken, I have worked a lot to not make it happen.
I am open for suggestions, and thanks in advance for you for reviewing (and hopefully approving) my suggestion.
Other things I have done:
pyproject.toml(to make it work with UV that I have used).hatch.tomlandpyproject.toml(to make it work with UV that I have used).